[denonmarantz] Run the Telnet socket in a dedicated thread #9511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad pool. Fixes openhab#9494 Signed-off-by: Jan-Willem Veldhuis <jwveldhuis@gmail.com>
J-N-K
requested changes
Dec 25, 2020
There was a problem hiding this comment.
I would suggest a differet approach: Instead of implementing Runnable in DenonMarantzTelnetClient you could extend Thread. Then in l. 64 while (i!sInterrupted()) and call disconnect after exiting the while-loop. In the connector you can call telnetClient.start() to start it and telnetClient.interrupt() to shut it down.
|
Also please set a name to the thread |
|
Thank you for fixing this. For thread naming see: #8216 |
Signed-off-by: Jan-Willem Veldhuis <jwveldhuis@gmail.com>
J-N-K
approved these changes
Dec 26, 2020
seaside1
pushed a commit
to seaside1/openhab-addons
that referenced
this pull request
Dec 28, 2020
) * Run the Telnet socket in a dedicated thread, not from the shared thread pool. Fixes openhab#9494 Signed-off-by: Jan-Willem Veldhuis <jwveldhuis@gmail.com>
seaside1
pushed a commit
to seaside1/openhab-addons
that referenced
this pull request
Dec 28, 2020
) * Run the Telnet socket in a dedicated thread, not from the shared thread pool. Fixes openhab#9494 Signed-off-by: Jan-Willem Veldhuis <jwveldhuis@gmail.com> Signed-off-by: Joseph Hagberg <joseph@zoidberg.se>
nowaterman
pushed a commit
to nowaterman/openhab-addons
that referenced
this pull request
Jan 19, 2021
) * Run the Telnet socket in a dedicated thread, not from the shared thread pool. Fixes openhab#9494
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/denonmarantz-binding-broken-after-update-to-oh3-1/124275/6 |
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
) * Run the Telnet socket in a dedicated thread, not from the shared thread pool. Fixes openhab#9494 Signed-off-by: Jan-Willem Veldhuis <jwveldhuis@gmail.com>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
) * Run the Telnet socket in a dedicated thread, not from the shared thread pool. Fixes openhab#9494 Signed-off-by: Jan-Willem Veldhuis <jwveldhuis@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9494