[openthermgateway] Add Diagnostics indication channel #9516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arjen Korevaar <a.korevaar@mephix.com>
Signed-off-by: Arjen Korevaar <a.korevaar@mephix.com>
ArjenKorevaar
changed the title
Signed-off-by: Arjen Korevaar <a.korevaar@mephix.com>
J-N-K
requested changes
Dec 27, 2020
...way/src/main/java/org/openhab/binding/openthermgateway/OpenThermGatewayBindingConstants.java
Outdated
Show resolved
Hide resolved
...way/src/main/java/org/openhab/binding/openthermgateway/OpenThermGatewayBindingConstants.java
Outdated
Show resolved
Hide resolved
…/openhab/binding/openthermgateway/OpenThermGatewayBindingConstants.java Co-authored-by: J-N-K <J-N-K@users.noreply.github.com> Signed-off-by: Arjen Korevaar <a.korevaar@mephix.com>
ArjenKorevaar
force-pushed
the
feature/9515
branch
from
a77a913 to
4183e7d
Compare
…/openhab/binding/openthermgateway/OpenThermGatewayBindingConstants.java Co-authored-by: J-N-K <J-N-K@users.noreply.github.com> Signed-off-by: Arjen Korevaar <a.korevaar@mephix.com>
ArjenKorevaar
force-pushed
the
feature/9515
branch
from
a066ed5 to
d199fb1
Compare
Yes, DataItemGroup.java contains a complete list of possible opentherm commands, based on the opentherm 2.2 specifications. So in this case adding a new channel to bind to the opentherm command was all that's needed. |
J-N-K
approved these changes
Dec 28, 2020
Signed-off-by: Arjen Korevaar <a.korevaar@mephix.com>
J-N-K
added
rebuild
|
Jenkins failed unrelated. |
seaside1
pushed a commit
to seaside1/openhab-addons
that referenced
this pull request
Dec 28, 2020
* Added Diagnostics indication channel Signed-off-by: Arjen Korevaar <a.korevaar@mephix.com>
seaside1
pushed a commit
to seaside1/openhab-addons
that referenced
this pull request
Dec 28, 2020
* Added Diagnostics indication channel Signed-off-by: Arjen Korevaar <a.korevaar@mephix.com> Signed-off-by: Joseph Hagberg <joseph@zoidberg.se>
seaside1
pushed a commit
to seaside1/openhab-addons
that referenced
this pull request
Dec 28, 2020
* Added Diagnostics indication channel Signed-off-by: Arjen Korevaar <a.korevaar@mephix.com> Signed-off-by: Joseph Hagberg <joseph@zoidberg.se>
seaside1
pushed a commit
to seaside1/openhab-addons
that referenced
this pull request
Dec 28, 2020
* Added Diagnostics indication channel Signed-off-by: Arjen Korevaar <a.korevaar@mephix.com> Signed-off-by: Joseph Hagberg <joseph@zoidberg.se>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
* Added Diagnostics indication channel Signed-off-by: Arjen Korevaar <a.korevaar@mephix.com>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
* Added Diagnostics indication channel Signed-off-by: Arjen Korevaar <a.korevaar@mephix.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Arjen Korevaar a.korevaar@mephix.com
Add Diagnostics indication channel
See #9515