-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved a number of the thread names #9581
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I'd like to suggest a slightly stricter naming convention (that is also followed in core bundles):
"The last segment should be camel case starting with small caps."
i.e. a
"OH-binding-" + uid + "-Caddx Communicator"
would become
"OH-binding-" + uid + "-caddxCommunicator"
Wdyt?
For my linuxinput binding I submitted #9582 to make it match more the expected thread names. Would it make sense for the core to provide a utility function to generate those names or even spawn threads? |
See openhab#9581 Signed-off-by: Thomas Weißschuh <thomas@t-8ch.de>
LGTM |
@t-8ch We have that already through the
which many already do. Creating own Threads within bindings should rather be avoided as an executor with a continuously running job should work in most cases as well. |
@kaikreuzer Thanks for the pointer with the |
Yes, including the ThingUID is indeed something you should do. Assembling the string can be done by yourself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
See #9581 Signed-off-by: Thomas Weißschuh <thomas@t-8ch.de>
Related to openhab#8216 Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
fc6357d
to
a4c91f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks @Hilbrand!
Related to openhab#8216 Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl> Signed-off-by: John Marshall <john.marshall.au@gmail.com>
See openhab#9581 Signed-off-by: Thomas Weißschuh <thomas@t-8ch.de>
Related to openhab#8216 Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
See openhab#9581 Signed-off-by: Thomas Weißschuh <thomas@t-8ch.de>
Related to openhab#8216 Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
Related to #8216