[deconz] refactoring and fix connection issues #9614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
* fix connection attempts when thing disposed Signed-off-by: Jan N. Klug <jan.n.klug@rub.de> * refactor session handling Signed-off-by: Jan N. Klug <jan.n.klug@rub.de> * rename Signed-off-by: Jan N. Klug <jan.n.klug@rub.de> * refactoring Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
* fix connection attempts when thing disposed Signed-off-by: Jan N. Klug <jan.n.klug@rub.de> * refactor session handling Signed-off-by: Jan N. Klug <jan.n.klug@rub.de> * rename Signed-off-by: Jan N. Klug <jan.n.klug@rub.de> * refactoring Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9604
Maybe related to #9517
Follow-Up to #9307
The root cause seems to be that the websocket-connection was restarted even if it was not closed before (
onErrordoes not necessarily close the session, but the code triggered a (delayed) restart of the connection). In some cases theonErrorwas followed by ?onClosewhich triggered an (immediate) restart of the connection, running two concurrent restart-attempts.