Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[http] fix missing escaping of URLs #9618

Merged
merged 1 commit into from
Dec 31, 2020
Merged

[http] fix missing escaping of URLs #9618

merged 1 commit into from
Dec 31, 2020

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Dec 31, 2020

Closes #9611

Signed-off-by: Jan N. Klug jan.n.klug@rub.de

@J-N-K
fix missing escaping of URLs
33ecd23 
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
@J-N-K J-N-K added the bug An unexpected problem or unintended behavior of an add-on label Dec 31, 2020
fwolter
fwolter approved these changes Dec 31, 2020
View reviewed changes
Copy link
Member

@fwolter fwolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fwolter fwolter merged commit 27afb1f into openhab:main Dec 31, 2020
@fwolter fwolter added this to the 3.1 milestone Dec 31, 2020
@J-N-K J-N-K deleted the http branch January 1, 2021 10:13
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/http-binding-oh3-url-encoding-received-parameter-is-invalid-creating-request-failed-conversion-m/115115/1

thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
@J-N-K @thinkingstone
[http] fix missing escaping of URLs (openhab#9618)
85ced92 
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
@J-N-K
[http] fix missing escaping of URLs (openhab#9618)
644f584 
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fwolter fwolter fwolter approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.
3 participants
@J-N-K @openhab-bot @fwolter