[MiHome] Add a Bridge property for the network interface to be used for multicast traffic #9619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or multicast traffic Signed-off-by: Ion Marusic <ion.marusic@gmail.com>
ratza
force-pushed
the
feature/multicast-interface-configuration
branch
from
99801a6
to
e15a831
Compare
|
@pboos can you take a look? |
fwolter
requested changes
Jan 30, 2021
| @@ -110,13 +110,17 @@ Just follow the instructions in ["Connecting devices to the gateway"](#connectin | |||
|
|
|||
| - The binding requires port `9898` to not be used by any other service on the system. | |||
| - Make sure multicast traffic is correctly routed between the gateway and your openHAB instance | |||
| - To correctly receive multicast traffic, when your OpenHAB machine is using multiple network interfaces, you might need to configure the optional `interface` property on the `Bridge` Thing, like so: | |||
There was a problem hiding this comment.
Please check all.
Suggested change
| - To correctly receive multicast traffic, when your OpenHAB machine is using multiple network interfaces, you might need to configure the optional `interface` property on the `Bridge` Thing, like so: | |
| - To correctly receive multicast traffic, when your openHAB machine is using multiple network interfaces, you might need to configure the optional `interface` property on the `Bridge` Thing, like so: |
There was a problem hiding this comment.
Reviewed the whole file and updated all relevant instances. Also fixed some other obvious typos.
| @@ -36,6 +36,14 @@ | |||
| <advanced>true</advanced> | |||
| </parameter> | |||
|
|
|||
| <parameter name="interface" type="text"> | |||
| <context>network-address</context> | |||
There was a problem hiding this comment.
The network-address context validates hostnames and IP adresses. AFAIK, there is no context for interface names. So, this should be removed.
There was a problem hiding this comment.
Removed. Unfortunately, I'm not accustomed with the effect of the "contexts", so I blindly replicated based on the other fields.
|
@ratza What's the state of this PR? |
Signed-off-by: Ion Marusic <ion.marusic@gmail.com>
Signed-off-by: Ion Marusic <ion.marusic@gmail.com>
My apologies, life took over. Just pushed the relevant changes. |
themillhousegroup
pushed a commit
to themillhousegroup/openhab2-addons
that referenced
this pull request
May 10, 2021
…or multicast traffic (openhab#9619) Signed-off-by: Ion Marusic <ion.marusic@gmail.com> Signed-off-by: John Marshall <john.marshall.au@gmail.com>
computergeek1507
pushed a commit
to computergeek1507/openhab-addons
that referenced
this pull request
Jul 13, 2021
…or multicast traffic (openhab#9619) Signed-off-by: Ion Marusic <ion.marusic@gmail.com>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
…or multicast traffic (openhab#9619) Signed-off-by: Ion Marusic <ion.marusic@gmail.com>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
…or multicast traffic (openhab#9619) Signed-off-by: Ion Marusic <ion.marusic@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[MiHome] Add a Bridge property for the network interface to be used for multicast traffic
This MR adds a property on the Bridge Thing to allow explicit configuration of the network interface name to which the MulticastSocket is bound.
When the computer running OpenHAB has more than one network interface configured (typically, a VLAN for your segregated IoT devices, and the other for your regular traffic like internet, OpenHAB panel access, etc), it could be that OpenHAB will attempt to listen for Multicast traffic of the Gateway on the wrong network interface. Depending on the OS the network interface chosen for binding the Multicast traffic depends on routing rules, default gateway or plain interface order (don't quote me on that). Couldn't find a specific document that describes the actual behavior, mostly because multiple networks configured for multicast is not considered the norm, hence has an undefined behavior. The solution is to bind to a specific network interface. Since there's no option to do it globally (for all Bindings) within OpenHAB and I read, somewhere on the forum, that it is expected for each binding to implement support separately, I've added this for the MiHome binding. I've also added a succinct description to the documentation.
Provides a graceful property to solve the issue described in #3239.
I've tested this in my own environment (Ubuntu, 2 VLANs), to be working correctly.
Signed-off-by: Ion Marusic ion.marusic@gmail.com