Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mqtt] Remove default for contact/switch alternate on/off message #9760

Merged
merged 1 commit into from
Jan 23, 2021

Conversation

jochen314
Copy link
Contributor

There is already a default for this : 'ON'/'OFF', 'Open'/'Close'
Why do we need another default?
The code does not honor the default, so the best is, to remove the default from the UI.

Fix for #9710

Signed-off-by: Jochen Klein <git@jochen.susca.de>
@jochen314 jochen314 requested a review from davidgraeff as a code owner January 8, 2021 22:17
@wborn wborn added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Jan 10, 2021
@Hilbrand Hilbrand added the bug An unexpected problem or unintended behavior of an add-on label Jan 12, 2021
@jochen314 jochen314 added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Jan 14, 2021
@J-N-K
Copy link
Member

J-N-K commented Jan 23, 2021

Sinc ethese defaults never worked, I think we can safely delete that.

@J-N-K J-N-K merged commit f2ed984 into openhab:main Jan 23, 2021
@J-N-K J-N-K added this to the 3.1 milestone Jan 23, 2021
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/openhab-3-1-milestone-discussion/116025/5

@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/switch-sanding-on-off-but-i-need-1-0/116696/13

themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
…#9760)

Signed-off-by: Jochen Klein <git@jochen.susca.de>
Signed-off-by: John Marshall <john.marshall.au@gmail.com>
@jochen314 jochen314 deleted the 9710 branch May 16, 2021 20:55
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MQTT] GUI Bug leads to Channel Updates don't follow the default rules for 'Contact'
5 participants