-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[miio] add support for viomi.waterheater.e1 #9798
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
marcelrv
added
the
enhancement
An enhancement or new feature for an existing add-on
label
Jan 12, 2021
cpmeister
reviewed
Jan 13, 2021
bundles/org.openhab.binding.miio/src/main/resources/database/viomi.waterheater.e1.json
Outdated
Show resolved
Hide resolved
…iomi.waterheater.e1.json Co-authored-by: Connor Petty <mistercpp2000@gmail.com>
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
cpmeister
approved these changes
Jan 13, 2021
Looks like the DCO check broke due to committing from the review suggestion. |
Manually verified sign-off. |
themillhousegroup
pushed a commit
to themillhousegroup/openhab2-addons
that referenced
this pull request
May 10, 2021
* [miio] add support for viomi.waterheater.e1 * Update bundles/org.openhab.binding.miio/src/main/resources/database/viomi.waterheater.e1.json * [miio] fix typo in readme Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> Signed-off-by: John Marshall <john.marshall.au@gmail.com>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
* [miio] add support for viomi.waterheater.e1 * Update bundles/org.openhab.binding.miio/src/main/resources/database/viomi.waterheater.e1.json * [miio] fix typo in readme Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
* [miio] add support for viomi.waterheater.e1 * Update bundles/org.openhab.binding.miio/src/main/resources/database/viomi.waterheater.e1.json * [miio] fix typo in readme Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Marcel Verpaalen marcel@verpaalen.com