[linky] One unique method to update daily and weekly data channels #9840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also check data availability for the peak consumption of yesterday Also log power peak data Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo
force-pushed
the
linky_dailyweeklychannels
branch
from
28bac8f
to
047f3d5
Compare
|
@clinique : first, this PR avoids calling a request twice when data from yesterday are not yet available in the morning. Second, it applies the data check availability for the yesterday peak consumption (I forgot this channel in my previopus improvement). |
|
@clinique : can you please have a look, the change is small ;) |
|
@lolodomo : I did, please see my 2 comments. |
|
@clinique : I see no comment from you ! Are you sure you submitted your review comments ? |
clinique
reviewed
Jan 24, 2021
...hab.binding.linky/src/main/java/org/openhab/binding/linky/internal/handler/LinkyHandler.java
Outdated
Show resolved
Hide resolved
...hab.binding.linky/src/main/java/org/openhab/binding/linky/internal/handler/LinkyHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
|
@cpmeister : would appreciate if you could review this one. |
Hilbrand
added
the
enhancement
lucacalcaterra
pushed a commit
to lucacalcaterra/openhab-addons
that referenced
this pull request
Feb 23, 2021
…penhab#9840) Also check data availability for the peak consumption of yesterday Also log power peak data Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
themillhousegroup
pushed a commit
to themillhousegroup/openhab2-addons
that referenced
this pull request
May 10, 2021
…penhab#9840) Also check data availability for the peak consumption of yesterday Also log power peak data Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: John Marshall <john.marshall.au@gmail.com>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
…penhab#9840) Also check data availability for the peak consumption of yesterday Also log power peak data Signed-off-by: Laurent Garnier <lg.hc@free.fr>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
…penhab#9840) Also check data availability for the peak consumption of yesterday Also log power peak data Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also check data availability for the peak consumption of yesterday
Also log power peak data
Signed-off-by: Laurent Garnier lg.hc@free.fr