[mqtt] Fix availability topics subscription after Brige Restart #9851
Conversation
albrechtf
force-pushed
the
fix_9850_mqtt_avail_topics
branch
from
1589787 to
fd14bca
Compare
Fixes openhab#9850 Signed-off-by: Florian Albrecht <cw.florian.albrecht@gmx.de>
albrechtf
force-pushed
the
fix_9850_mqtt_avail_topics
branch
from
fd14bca to
a956bce
Compare
|
CI build fails (stops) after 1 hour. Appreciate any support how to "fix" that :-) |
wborn
added
rebuild
| } else { | ||
| clearAllAvailabilityTopics(); | ||
| } | ||
| initializeAvailabilityTopicsFromConfig(); |
There was a problem hiding this comment.
From what I can tell, due to your changes in start above, topic subscription will occur automatically as part of the call to super.initialize(). So you don't need to call initializeAvailabilityTopicsFromConfig() here at all. In fact it might be better if you don't since that way config errors will prevent further initialization, as they should.
You should also make changes in AbstractMQTTThingHandler.bridgeStatusChanged to make sure that the handler isn't offline due to config errors before it tries initializing a connection.
| start(connection).get(subscribeTimeout, TimeUnit.MILLISECONDS); | ||
| } catch (InterruptedException | ExecutionException | TimeoutException ignored) { |
There was a problem hiding this comment.
I'd prefer if you made sure that the offline status would include the exception message, just like it did before.
fwolter
added
the
awaiting feedback
|
@albrechtf What's the state of this PR? |
|
@fwolter The state is that my PR was not good enough for the maintainers, and I currently don't have time to adjust it according to their comments. Feel free to provide additional changes / patches so it may be good enough for merging, that would be very much appreciated. |
fwolter
added
rebuild
fwolter
removed
the
awaiting feedback
Fixes openhab#9850 Signed-off-by: Florian Albrecht <cw.florian.albrecht@gmx.de> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
Fixes openhab#9850 Signed-off-by: Florian Albrecht <cw.florian.albrecht@gmx.de> Signed-off-by: Michael Schmidt <mi.schmidt.83@gmail.com>
Fixes openhab#9850 Signed-off-by: Florian Albrecht <cw.florian.albrecht@gmx.de>
Fixes openhab#9850 Signed-off-by: Florian Albrecht <cw.florian.albrecht@gmx.de>
Fixes openhab#9850 Signed-off-by: Florian Albrecht <cw.florian.albrecht@gmx.de>
Fixes openhab#9850 Signed-off-by: Florian Albrecht <cw.florian.albrecht@gmx.de> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
This is a Patch Proposal for #9850. It is the "easy" variant of the fix; the major design flaws in classes
AbstractMQTTThingHandlerandGenericMQTTThingHandler(especially regarding availability topics) are not addressed.A Unit Test is included.