[enphase] Initial contribution #9883

Hilbrand · 2021-01-20T13:15:53Z

Temporary install until merged:

Open console:

openhab-cli console

And install binding:

bundle:install https://openhab.jfrog.io/artifactory/libs-pullrequest-local/org/openhab/addons/bundles/org.openhab.binding.enphase/3.1.0-SNAPSHOT/org.openhab.binding.enphase-3.1.0-SNAPSHOT.jar
bundle:start org.openhab.binding.enphase

openhab-bot · 2021-01-21T14:55:28Z

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/new-binding-enphase-envoy-solar-system-gateway/44449/41

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>

Skinah

I hope some of these are useful feedback, if not just ignore as some may reflect my lack of java and coding knowledge.

...ding.enphase/src/main/java/org/openhab/binding/enphase/internal/EnphaseBindingConstants.java

bundles/org.openhab.binding.enphase/README.md

...b.binding.enphase/src/main/java/org/openhab/binding/enphase/internal/EnvoyConfiguration.java

bundles/org.openhab.binding.enphase/README.md

...ing.enphase/src/main/java/org/openhab/binding/enphase/internal/EnvoyConnectionException.java

bundles/org.openhab.binding.enphase/src/main/resources/OH-INF/thing/thing-types.xml

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>

...main/java/org/openhab/binding/enphase/internal/discovery/EnphaseDevicesDiscoveryService.java

Skinah

LGTM

.../src/main/java/org/openhab/binding/enphase/internal/discovery/EnvoyDiscoveryParticipant.java

cpmeister · 2021-01-26T05:10:19Z

...g.enphase/src/main/java/org/openhab/binding/enphase/internal/handler/EnvoyBridgeHandler.java

+            updateStatus(ThingStatus.OFFLINE, ThingStatusDetail.CONFIGURATION_ERROR, "Serial Number is not valid");
+        }
+        if (configuration.hostname.isEmpty()) {
+            updateStatus(ThingStatus.ONLINE, ThingStatusDetail.CONFIGURATION_PENDING,


Can it really be considered online at this point?

Yes good question. I didn't know how to handle it otherwise. Looking at the status table: https://www.openhab.org/docs/concepts/things.html#status-details This comes closest to what would give some meaningful status in this case. Other status are not expected to have details and thus are not expected to have additional detail text. If you have another idea let me know.

I've changed this so set to UNKNOWN at this point, and to set to OFF_LINE if it doesn't have an ip address.

...g.enphase/src/main/java/org/openhab/binding/enphase/internal/handler/EnvoyBridgeHandler.java

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>

lsiepel · 2021-02-07T21:17:42Z

Today i change some wiring and forgot to plug the ethernet cable in. :-| The Envoy remained in Status Online / config_pending / waiting to retrieve ip address of the envoy gateway. This was there for hours. I'm not sure how to fix, but i would have expected an offline state after a while, Device unreachable or something like that.

Hilbrand · 2021-02-08T11:07:51Z

@lsiepel I did some checks. At first sight it looks like the underlying mdns discovery in openhab-core doesn't recover correctly from a situation where network is reconnected. This means it won't work in the enphase binding here as the setting of the ip address depends on the discovery. A restart of openHAB with network connected should fix the issue or edit the thing, click advanced and add the ip address manually.

Hilbrand · 2021-02-08T18:08:32Z

@lsiepel I did some tests. It looks like the underlying mdns of openhab-core isn't able to correctly recover from network changes. A restart of openHAB seems to be required. In this case you can also manually configure the ip address by clicking show advanced on the thing configuration in the ui.

lsiepel · 2021-02-08T20:08:26Z

I fixed it by attaching the cable ;-) and disabling/enabling the thing, so no worries. The point i tried to make was that the error was not related to the configuration and waiting any longer would not help. Not a big issue'but i would expected a status offline.

fwolter · 2021-04-02T21:14:12Z

...g.enphase/src/main/java/org/openhab/binding/enphase/internal/handler/EnvoyBridgeHandler.java

+        } catch (final EnvoyNoHostnameException e) {
+            // ignore hostname exception here. It's already handled by others.
+        } catch (final EnvoyConnectionException e) {
+            logger.trace("refreshInverters connection problem", e);


It seems unreasonable to log the stacktrace when the network fails.

It's therefor logged to trace. To have the ability to get debug information just in case something explainable is triggered.

fwolter · 2021-04-02T21:15:22Z

...g.enphase/src/main/java/org/openhab/binding/enphase/internal/handler/EnvoyBridgeHandler.java

+    private final EnvoyConnector connector;
+    private final EnvoyHostAddressCache envoyHostnameCache;
+
+    private @NonNullByDefault({}) EnvoyConfiguration configuration;


You could assign an empty configuration object to get rid of the null disabling.

fwolter · 2021-04-02T21:15:55Z

...g.enphase/src/main/java/org/openhab/binding/enphase/internal/handler/EnvoyBridgeHandler.java

+                logger.info(
+                        "This Ephase Envoy device ({}) doesn't seem to support json data. So not all channels are set.",
+                        getThing().getUID());


Logging to info should be used sparsely e.g. a newly started component or a user file that has been loaded. This could be debug. Please check all.

The logging here is done to inform the user about available of certain features of their devices. It's only done at startup of the thing. The other logging is to log a configuration setting has been automatically adjusted. Therefor I think is within the spirit of of log to info.

fwolter · 2021-04-02T21:21:01Z

bundles/org.openhab.binding.enphase/src/main/resources/OH-INF/i18n/enphase_en.properties

+envoy.cond_flags.acb_ctrl.cellminvoltagewarning=Cell Min Voltage Warning
+envoy.cond_flags.acb_ctrl.cibcanerror=CIB CAN Error
+envoy.cond_flags.acb_ctrl.cibimageerror=CIB Image Error
+envoy.cond_flags.acb_ctrl.cibspierror=CIB SPI Error"


Is the " inteded? Same for below.

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>

fwolter

LGTM

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl> Signed-off-by: John Marshall <john.marshall.au@gmail.com>

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>

Hilbrand added the new binding If someone has started to work on a binding. For a new binding PR. label Jan 20, 2021

Hilbrand requested a review from a team January 20, 2021 13:15

Hilbrand added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Jan 20, 2021

Hilbrand force-pushed the enphase branch from 7b97b76 to 48f8264 Compare January 21, 2021 14:52

Hilbrand force-pushed the enphase branch from 48f8264 to 0c560c5 Compare January 21, 2021 15:44

[enphase] Initial contribution

8d859b0

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>

Hilbrand force-pushed the enphase branch from 0c560c5 to 8d859b0 Compare January 21, 2021 16:50

Skinah reviewed Jan 23, 2021

View reviewed changes

Hilbrand added 2 commits January 23, 2021 22:09

[enphase] review comments

4412b0e

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>

[enphase] Some small improvements

7a2f122

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>

Hilbrand requested a review from Skinah January 23, 2021 23:00

Hilbrand mentioned this pull request Jan 24, 2021

openHAB 1 addon compatibility overview with openHAB 3 #6179

Closed

Hilbrand added the oh1 migration Relates to migrating an openHAB 1 addon to openHAB 2 label Jan 24, 2021

Skinah reviewed Jan 25, 2021

View reviewed changes

...main/java/org/openhab/binding/enphase/internal/discovery/EnphaseDevicesDiscoveryService.java Show resolved Hide resolved

Skinah approved these changes Jan 25, 2021

View reviewed changes

cpmeister requested changes Jan 26, 2021

View reviewed changes

[enphase] Review comments

d814d2f

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>

Hilbrand added the rebuild Triggers Jenkins PR build label Jan 27, 2021

wborn removed the rebuild Triggers Jenkins PR build label Jan 27, 2021

Hilbrand requested a review from cpmeister January 27, 2021 18:47

fwolter requested changes Apr 2, 2021

View reviewed changes

Review comments

2377875

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>

Hilbrand force-pushed the enphase branch from 5de779a to 2377875 Compare April 8, 2021 19:30

Hilbrand requested a review from fwolter April 8, 2021 19:31

fwolter approved these changes Apr 9, 2021

View reviewed changes

fwolter added the cre Coordinated Review Effort label Apr 9, 2021

fwolter merged commit 53d1689 into openhab:main Apr 11, 2021

fwolter removed the cre Coordinated Review Effort label Apr 11, 2021

fwolter added this to the 3.1 milestone Apr 11, 2021

Hilbrand deleted the enphase branch April 11, 2021 19:17

themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021

[enphase] Initial contribution (openhab#9883)

95a3c9f

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl> Signed-off-by: John Marshall <john.marshall.au@gmail.com>

computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021

[enphase] Initial contribution (openhab#9883)

334b384

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>

thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021

[enphase] Initial contribution (openhab#9883)

12857c8

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>

marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022

[enphase] Initial contribution (openhab#9883)

2e0f52b

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[enphase] Initial contribution #9883

[enphase] Initial contribution #9883

Hilbrand commented Jan 20, 2021 •

edited

Loading

openhab-bot commented Jan 21, 2021

Skinah left a comment

Skinah left a comment

cpmeister Jan 26, 2021

Hilbrand Jan 26, 2021

Hilbrand Apr 8, 2021

lsiepel commented Feb 7, 2021

Hilbrand commented Feb 8, 2021

Hilbrand commented Feb 8, 2021

lsiepel commented Feb 8, 2021

fwolter Apr 2, 2021

Hilbrand Apr 8, 2021

fwolter Apr 2, 2021

fwolter Apr 2, 2021

Hilbrand Apr 8, 2021

fwolter Apr 2, 2021

fwolter left a comment

[enphase] Initial contribution #9883

[enphase] Initial contribution #9883

Conversation

Hilbrand commented Jan 20, 2021 • edited Loading

openhab-bot commented Jan 21, 2021

Skinah left a comment

Choose a reason for hiding this comment

Skinah left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lsiepel commented Feb 7, 2021

Hilbrand commented Feb 8, 2021

Hilbrand commented Feb 8, 2021

lsiepel commented Feb 8, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fwolter left a comment

Choose a reason for hiding this comment

Hilbrand commented Jan 20, 2021 •

edited

Loading