-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gpio] Update README.md #9899
[gpio] Update README.md #9899
Conversation
ExecStart= | ||
ExecStart=/usr/bin/pigpiod |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are there two ExecStart
s?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because this is what the raspi-config script adds to the pigpiod config file and I copied verbatim (in case it matters).
https://github.com/RPi-Distro/raspi-config/blob/74885481d8f311ab3875b6601153132552b41d67/raspi-config#L1616
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems an error to me. Can you test if it still works if you remove the empty ExecStart=
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to be to override the default values. See https://bugzilla.redhat.com/show_bug.cgi?id=756787. So I guess it is to be sure no default settings are present. That would mean even if @SebBoulet would test this on his system and it works, it might not work for other people who have other configurations. So I would say this is legitimate use case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't find that info when doing a quick search. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Added instructions in case raspi-config is not available. Signed-off-by: Seb Boulet <SebBoulet@users.noreply.github.com>
Co-authored-by: Hilbrand Bouwkamp <hilbrand@h72.nl> Signed-off-by: Seb Boulet <SebBoulet@users.noreply.github.com>
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/gpio-new-gpio-binding-for-oh3/113943/16 |
Co-authored-by: Hilbrand Bouwkamp <hilbrand@h72.nl> Signed-off-by: Seb Boulet <SebBoulet@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…hab#9899) Signed-off-by: Seb Boulet <SebBoulet@users.noreply.github.com>
…hab#9899) Signed-off-by: Seb Boulet <SebBoulet@users.noreply.github.com> Signed-off-by: John Marshall <john.marshall.au@gmail.com>
…hab#9899) Signed-off-by: Seb Boulet <SebBoulet@users.noreply.github.com>
…hab#9899) Signed-off-by: Seb Boulet <SebBoulet@users.noreply.github.com>
Added instructions in case raspi-config is not available.