Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jdbc] Do not define bundle related versions in OH feature file #9904

Merged
merged 1 commit into from
Jan 22, 2021

Conversation

cweitkamp
Copy link
Contributor

@cweitkamp cweitkamp commented Jan 21, 2021

  • Do not define bundle related versions in OH feature file

See #9810 (comment)

Related to #8883
Related to #9810

Signed-off-by: Christoph Weitkamp github@christophweitkamp.de

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
@cweitkamp cweitkamp requested a review from a team as a code owner January 21, 2021 21:20
@cweitkamp cweitkamp added the bug An unexpected problem or unintended behavior of an add-on label Jan 21, 2021
@wborn wborn added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Jan 22, 2021
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to create some resource processing on all feature.xml files in bundles one day and then assemble the complete feature.xml file from the processed files in target/ instead. That might allow for easily using the properties defined in the bundle POMs in bundle feature.xml files. 🙂

@wborn wborn merged commit 37bc57f into openhab:main Jan 22, 2021
@wborn wborn added this to the 3.1 milestone Jan 22, 2021
@cweitkamp cweitkamp deleted the bugfix-feature branch January 22, 2021 13:12
lsiepel added a commit to lsiepel/openhab-addons that referenced this pull request Feb 9, 2021
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Signed-off-by: John Marshall <john.marshall.au@gmail.com>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants