-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mystrom] Add support for myStrom Bulb #9910
Conversation
Add properties to myStrom devices and an action to refresh the properties. Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your first contribution. I have left some comments inside. If you need assistance, plese ping me.
...nding.mystrom/src/main/java/org/openhab/binding/mystrom/internal/MyStromAbstractHandler.java
Outdated
Show resolved
Hide resolved
...nding.mystrom/src/main/java/org/openhab/binding/mystrom/internal/MyStromAbstractHandler.java
Outdated
Show resolved
Hide resolved
...nding.mystrom/src/main/java/org/openhab/binding/mystrom/internal/MyStromAbstractHandler.java
Outdated
Show resolved
Hide resolved
...nding.mystrom/src/main/java/org/openhab/binding/mystrom/internal/MyStromAbstractHandler.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.mystrom/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.mystrom/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
...b.binding.mystrom/src/main/java/org/openhab/binding/mystrom/internal/MyStromBulbHandler.java
Outdated
Show resolved
Hide resolved
...nding.mystrom/src/main/java/org/openhab/binding/mystrom/internal/MyStromAbstractHandler.java
Outdated
Show resolved
Hide resolved
...nding.mystrom/src/main/java/org/openhab/binding/mystrom/internal/MyStromAbstractHandler.java
Outdated
Show resolved
Hide resolved
...b.binding.mystrom/src/main/java/org/openhab/binding/mystrom/internal/MyStromBulbHandler.java
Outdated
Show resolved
Hide resolved
I think I have adjusted everything. But before I commit, I have one more question. |
Not sure. Maybe adding |
Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some last small comments. Otherwise looks good to me.
...b.binding.mystrom/src/main/java/org/openhab/binding/mystrom/internal/MyStromBulbHandler.java
Outdated
Show resolved
Hide resolved
...b.binding.mystrom/src/main/java/org/openhab/binding/mystrom/internal/MyStromBulbHandler.java
Outdated
Show resolved
Hide resolved
Co-authored-by: J-N-K <J-N-K@users.noreply.github.com>
Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch>
Override DCO because "commit suggestion" was used. Waiting for Jenkins before merge. Thanks. |
50d3366
to
b080bc6
Compare
Jenkins failed prior to building mystrom. Rebuild. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks a lot for this contribution
bundles/org.openhab.binding.mystrom/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.mystrom/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
channel type system.color-temperature is used and values mapped from 1-18 to 0-100% Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch>
Format power state Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch>
There is still DCO issue because I used once "commit suggestion". Can I do something to make the check pass? |
Kai's findings seem to be addressed appropriately. |
* Add support to myStrom Bulb Add properties to myStrom devices and an action to refresh the properties. Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch> * Fixes according to review comments Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch> * Update bundles/org.openhab.binding.mystrom/README.md Co-authored-by: J-N-K <J-N-K@users.noreply.github.com> * Fixes according to review comments Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch> * Use system color temperature channel type channel type system.color-temperature is used and values mapped from 1-18 to 0-100% Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch> * Better tracking of colour and brightness values Format power state Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch> Co-authored-by: J-N-K <J-N-K@users.noreply.github.com> Signed-off-by: John Marshall <john.marshall.au@gmail.com>
* Add support to myStrom Bulb Add properties to myStrom devices and an action to refresh the properties. Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch> * Fixes according to review comments Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch> * Update bundles/org.openhab.binding.mystrom/README.md Co-authored-by: J-N-K <J-N-K@users.noreply.github.com> * Fixes according to review comments Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch> * Use system color temperature channel type channel type system.color-temperature is used and values mapped from 1-18 to 0-100% Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch> * Better tracking of colour and brightness values Format power state Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch> Co-authored-by: J-N-K <J-N-K@users.noreply.github.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
* Add support to myStrom Bulb Add properties to myStrom devices and an action to refresh the properties. Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch> * Fixes according to review comments Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch> * Update bundles/org.openhab.binding.mystrom/README.md Co-authored-by: J-N-K <J-N-K@users.noreply.github.com> * Fixes according to review comments Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch> * Use system color temperature channel type channel type system.color-temperature is used and values mapped from 1-18 to 0-100% Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch> * Better tracking of colour and brightness values Format power state Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch> Co-authored-by: J-N-K <J-N-K@users.noreply.github.com>
* Add support to myStrom Bulb Add properties to myStrom devices and an action to refresh the properties. Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch> * Fixes according to review comments Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch> * Update bundles/org.openhab.binding.mystrom/README.md Co-authored-by: J-N-K <J-N-K@users.noreply.github.com> * Fixes according to review comments Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch> * Use system color temperature channel type channel type system.color-temperature is used and values mapped from 1-18 to 0-100% Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch> * Better tracking of colour and brightness values Format power state Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch> Co-authored-by: J-N-K <J-N-K@users.noreply.github.com>
* Add support to myStrom Bulb Add properties to myStrom devices and an action to refresh the properties. Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch> * Fixes according to review comments Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch> * Update bundles/org.openhab.binding.mystrom/README.md Co-authored-by: J-N-K <J-N-K@users.noreply.github.com> * Fixes according to review comments Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch> * Use system color temperature channel type channel type system.color-temperature is used and values mapped from 1-18 to 0-100% Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch> * Better tracking of colour and brightness values Format power state Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch> Co-authored-by: J-N-K <J-N-K@users.noreply.github.com>
Add support for myStrom Bulb
Add properties to myStrom devices and an action to refresh the properties.
closes #9818
Signed-off-by: Frederic Chastagnol fchastagnol@fredoware.ch