[miio] validate response id matching command id #9966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR prevents out of sync issues in case devices are too slow to respond or the timeout is set too short. Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
fwolter
requested changes
Jan 26, 2021
...g.miio/src/main/java/org/openhab/binding/miio/internal/transport/MiIoAsyncCommunication.java
Outdated
Show resolved
Hide resolved
...g.miio/src/main/java/org/openhab/binding/miio/internal/transport/MiIoAsyncCommunication.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
marcelrv
added
rebuild
kaikreuzer
added
rebuild
|
@cpmeister / @fwolter would you mind reviewing this, so it can still make the 3.1M1this weekend. Would be good to have this fix in. |
fwolter
approved these changes
Jan 30, 2021
lsiepel
added a commit
to lsiepel/openhab-addons
that referenced
this pull request
Feb 9, 2021
This reverts commit f58df8f.
lucacalcaterra
pushed a commit
to lucacalcaterra/openhab-addons
that referenced
this pull request
Feb 23, 2021
* [miio] validate response id matching command id This PR prevents out of sync issues in case devices are too slow to respond or the timeout is set too short. Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] spotless adding space Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] update based on review Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
themillhousegroup
pushed a commit
to themillhousegroup/openhab2-addons
that referenced
this pull request
May 10, 2021
* [miio] validate response id matching command id This PR prevents out of sync issues in case devices are too slow to respond or the timeout is set too short. Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] spotless adding space Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] update based on review Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> Signed-off-by: John Marshall <john.marshall.au@gmail.com>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
* [miio] validate response id matching command id This PR prevents out of sync issues in case devices are too slow to respond or the timeout is set too short. Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] spotless adding space Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] update based on review Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
* [miio] validate response id matching command id This PR prevents out of sync issues in case devices are too slow to respond or the timeout is set too short. Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] spotless adding space Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] update based on review Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents out of sync issues in case devices are too slow to
respond or the timeout is set too short.
closes #9896
Signed-off-by: Marcel Verpaalen marcel@verpaalen.com