Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some icons aren't loaded anymore #3733

Open
mueller-ma opened this issue Jul 5, 2024 · 1 comment · Fixed by #3743
Open

Some icons aren't loaded anymore #3733

mueller-ma opened this issue Jul 5, 2024 · 1 comment · Fixed by #3743
Labels
bug Indicates an unexpected problem or unintended behavior

Comments

@mueller-ma
Copy link
Member

Actual behaviour

Some icons aren't loaded anymore in Sitemaps and notifications. My guess is that the original fetch was unsuccessful and that this error has been cached.
@mueller-ma mueller-ma added the bug Indicates an unexpected problem or unintended behavior label Jul 5, 2024
mueller-ma added a commit to mueller-ma/openhab.android that referenced this issue Jul 11, 2024
@mueller-ma
Don't cache responses with 0 content length
d81282f 
I noticed that myopenhab.org sometimes returns http code 200 for an icon and a valid svg content type, but the content length is 0. In that case, change to http code to 500 to avoid caching.

Fixes openhab#3733

Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>
@mueller-ma mueller-ma mentioned this issue Jul 11, 2024
Merged
mueller-ma added a commit that referenced this issue Jul 16, 2024
@mueller-ma
Don't cache responses with 0 content length (#3743)
d8c8e2d 
I noticed that myopenhab.org sometimes returns http code 200 for an icon and a valid svg content type, but the content length is 0. In that case, change to http code to 500 to avoid caching.

Fixes #3733

Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>
@mueller-ma mueller-ma reopened this Jul 18, 2024
@mueller-ma
Copy link
Member Author

I noticed that myopenhab.org sometimes returns http code 200 for an icon and a valid svg content type, but the content length is 0. In that case, change to http code to 500 to avoid caching.

#3743 went too far and made valid requests without body to fail, see #3759

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't cache responses with 0 content length mueller-ma/openhab.android
1 participant
@mueller-ma