Icons misplaced #3786
Labels
bug
Indicates an unexpected problem or unintended behavior
Comments
|
The switch-with-mappings icon issue likely is #3773. The 'white background' one likely is one I also have seen once, but didn't have a chance of investigation yet: It looks like the icon and the loading placeholder ('glowing' frame) are both shown simultaneously. |
|
Then I guess we can close this as duplicate and/or should create an issue for
|
|
We can keep this one for that issue. As far as I can tell, this placeholder (skeleton) + image issue happens due to race conditions when views are reused, because
The solution for this, as far as I can tell, is avoiding the magic implicit skeleton creation. Will think about it further, though. |
|
Evidence of speculation above: I've added some debug statements to One can see clearly that
|
maniac103
added a commit
to maniac103/openhab.android
that referenced
this issue
Jul 30, 2024
The 'automagic' skeleton addition caused two issues: - Misplaced icon in section switches (openhab#3773) This was caused by constraints in the widget's ConstraintLayout referencing the WidgetImageView's ID, which was no longer present after replacing it by the SkeletonLayout - Skeleton and image shown at the same time (mentioned in openhab#3786) This was caused by WidgetAdapter and SkeletonLayout both simultaneously modifying the visibility flag of the WidgetImageView, again caused by silent replacement of WidgetImageView by SkeletonLayout Fix both issues by changing the approach: Instead of silently replacing the view, make WidgetImageView inherit from SkeletonLayout and make it redirect external calls to an internal ImageView instance. Fixes openhab#3773, openhab#3786 Signed-off-by: Danny Baumann <dannybaumann@web.de>
mueller-ma
pushed a commit
that referenced
this issue
Jul 30, 2024
The 'automagic' skeleton addition caused two issues: - Misplaced icon in section switches (#3773) This was caused by constraints in the widget's ConstraintLayout referencing the WidgetImageView's ID, which was no longer present after replacing it by the SkeletonLayout - Skeleton and image shown at the same time (mentioned in #3786) This was caused by WidgetAdapter and SkeletonLayout both simultaneously modifying the visibility flag of the WidgetImageView, again caused by silent replacement of WidgetImageView by SkeletonLayout Fix both issues by changing the approach: Instead of silently replacing the view, make WidgetImageView inherit from SkeletonLayout and make it redirect external calls to an internal ImageView instance. Fixes #3773, #3786 Signed-off-by: Danny Baumann <dannybaumann@web.de>
|
Fixed with #3787 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Disclaimer: There are some open issues about icons but I am not sure weather any of these covers the following issue. If so please close this one.
Actual behaviour
Since a recent version of the android app the icons seem to be misplaced sometimes:
After scrolling in the window or reloading the icon seem to be placed where they belong.
Clearing the cache does not help.
In the following image I noticed that an icon got a background it should not have:
The original image has no white background.
On iOS the icons work as expected:
It does not matter whether the connection is local or via the cloud.
Expected behaviour
The icons should all be aligned the same way.
Steps to reproduce
See code below
Environment data
Client
Server
Logs
App log
Click to expand
---------------.txt
Code for first image:
Frame label="Saugen" { Switch item=Staubsauger_System_Staubsauger_Steuerung mappings=["vacuum"="Start", "pause"="Pause", "dock"="Dock"] visibility=[Staubsauger_System_Staubsauger_Status != "Charging"] Text item=Staubsauger_System_Staubsauger_Status visibility=[!= "Charging"] Selection item=Staubsauger_System_Staubsauger_Saugleistung mappings=[101="Leise", 102="Normal", 103="Turbo", 104="Maximal"] Text item=Staubsauger_System_Raum_Gruppe visibility=[Staubsauger_System_Staubsauger_Status == "Charging"] { Switch item=Staubsauger_System_Raum_16 Switch item=Staubsauger_System_Raum_23 Switch item=Staubsauger_System_Raum_17 Switch item=Staubsauger_System_Raum_20 Switch item=Staubsauger_System_Raum_18 Switch item=Staubsauger_System_Raum_19 } Slider item=Staubsauger_System_Reinigungszyklen minValue=1 maxValue=3 visibility=[Staubsauger_System_Staubsauger_Status == "Charging"] Switch item=Staubsauger_System_Start label="" mappings=[ON="Start"] visibility=[Staubsauger_System_Raum_Gruppe != 0] Image item=Staubsauger_System_Staubsauger_Karte visibility=[!= UNDEF] ....Code for second image:
Frame label="Bindings" { Switch item=System_System_Binding_AmazonEchoControl mappings=["Stop"="STOP", "Restart"="NEUSTART", "Start"="START"] Switch item=System_System_Binding_AndroidTV mappings=["Stop"="STOP", "Restart"="NEUSTART", "Start"="START"] Switch item=System_System_Binding_ESPHome mappings=["Stop"="STOP", "Restart"="NEUSTART", "Start"="START"] Switch item=System_System_Binding_Nanoleaf mappings=["Stop"="STOP", "Restart"="NEUSTART", "Start"="START"] Switch item=System_System_Binding_Miio mappings=["Stop"="STOP", "Restart"="NEUSTART", "Start"="START"] Switch item=System_System_Binding_Network mappings=["Stop"="STOP", "Restart"="NEUSTART", "Start"="START"] Switch item=System_System_Binding_OpenWeatherMap mappings=["Stop"="STOP", "Restart"="NEUSTART", "Start"="START"] Switch item=System_System_Binding_Hue mappings=["Stop"="STOP", "Restart"="NEUSTART", "Start"="START"] Switch item=System_System_Binding_Shelly mappings=["Stop"="STOP", "Restart"="NEUSTART", "Start"="START"] Switch item=System_System_Binding_Spotify mappings=["Stop"="STOP", "Restart"="NEUSTART", "Start"="START"] Switch item=System_System_Binding_Systeminfo mappings=["Stop"="STOP", "Restart"="NEUSTART", "Start"="START"] }Code for third image:
Frame label="Klima" { Text item=Klima_System_Durchschnittstemperatur { Text item=Klima_Badezimmer_Temperatur label="Badezimmer" Text item=Klima_Flur_Temperatur label="Flur" Text item=Klima_Kueche_Temperatur label="Küche" Text item=Klima_Schlafzimmer_Temperatur label="Schlafzimmer" } Text item=Klima_System_Aussentemperatur_Zusammengesetzt }The text was updated successfully, but these errors were encountered: