Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MQTT] PeriodicReconnectStrategy: default parameters inversed #1200

Closed
lolodomo opened this issue Nov 11, 2019 · 3 comments · Fixed by #1203
Closed

[MQTT] PeriodicReconnectStrategy: default parameters inversed #1200

lolodomo opened this issue Nov 11, 2019 · 3 comments · Fixed by #1203

Comments

@lolodomo
Copy link
Contributor

lolodomo commented Nov 11, 2019 •
edited
Loading

https://github.com/openhab/openhab-core/blob/master/bundles/org.openhab.core.io.transport.mqtt/src/main/java/org/eclipse/smarthome/io/transport/mqtt/reconnect/PeriodicReconnectStrategy.java#L46

It looks to me that "reconnect frequency" and "try the first reconnect after" parameters are reversed, the first is set to 10s and the second to 60s, the reverse of the method comment.
@lolodomo
Copy link
Contributor Author

@davidgraeff to confirm the bug

@davidgraeff
Copy link
Member

Confirmed

@lolodomo
Copy link
Contributor Author

Ok, I prepare a PR.

@lolodomo lolodomo mentioned this issue Nov 11, 2019
Merged
cweitkamp pushed a commit that referenced this issue Nov 11, 2019
@lolodomo @cweitkamp
[mqtt] PeriodicReconnectStrategy: fix fields init (#1203)
16a9ff0 
Fixes #1200

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this issue Jul 11, 2023
@lolodomo @splatch
[mqtt] PeriodicReconnectStrategy: fix fields init (openhab#1203)
42ea967 
Fixes openhab#1200

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
GitOrigin-RevId: 16a9ff0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[mqtt] PeriodicReconnectStrategy: Fixed fields initialization
2 participants
@davidgraeff @lolodomo