Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rest] Charts have always a label #1351

Closed
mueller-ma opened this issue Feb 1, 2020 · 3 comments
Closed

[Rest] Charts have always a label #1351

mueller-ma opened this issue Feb 1, 2020 · 3 comments

Comments

@mueller-ma
Copy link
Member

The rest api always returns a label for charts. If I don't set a label explicitly, the rest api will return the item name (that is displayed in the chart) as label.
IMO this behavior is bad, since software using that api cannot distinguish between "human readable label" and "automatic generated label". In latter case, the client doesn't want to display the label at all or replace it with Chart.

Rosi2143 pushed a commit to Rosi2143/openhab-core that referenced this issue Dec 26, 2020
Signed-off-by: Bob Adair <bob.github@att.net>
@J-N-K
Copy link
Member

J-N-K commented May 5, 2024

Is this still the case and if so, how can I reproduce it?

@lolodomo
Copy link
Contributor

lolodomo commented May 6, 2024

There was a field "source" added few months ago by PR #3804 It allows knowing the source of the label
I guess this is fine now and we can probably close this issue.
@mueller-ma :please confirm.

@mueller-ma
Copy link
Member Author

I cannot reproduce this anymore. When the chart has no label and the item of the chart has no label, the api returns label="".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants