Expiration Timer on Groups never expires when Group State Changes due to an Item State change

[cweitkamp]

It is now possible to set an expiration Timer on a Group Item. This timer expires if you send a command to the group or update its state. But the timer never expires when the Group State Changes due to an Item State change.

Group:Switch(ON,OFF) testGroup { expire="30s,command=OFF" }
Switch testSwitch (testGroup)

[t2000]

The reason for this is that the ExpireManager does not listen to GroupItemStateChangedEvents. I have a PR for this.

[t2000]

And for the record, the above example is wrong. the function is missing in the group definition:

Group:Switch:OR(ON,OFF) testGroup { expire="30s,command=OFF" }
Switch testSwitch (testGroup)

With my fix, the group will expire as expected:

18:04:05.538 [eventexecutor-1] TRACE o.o.c.internal.items.ExpireManager:144 - Received 'ON' for item testSwitch
18:04:05.548 [eventexecutor-1] DEBUG o.o.core.common.ThreadPoolManager:159 - Created thread pool 'items' with size 5
18:04:05.554 [eventexecutor-1] TRACE o.o.c.internal.items.ExpireManager:144 - Received 'ON' for item testSwitch
18:04:05.555 [eventexecutor-1] TRACE o.o.c.internal.items.ExpireManager:144 - Received 'ON' for item testGroup
18:04:05.559 [eventexecutor-1] DEBUG o.o.c.internal.items.ExpireManager:159 - Item testGroup will expire (with 'OFF' command) in PT30S ms
18:04:32.479 [OH-common-5] DEBUG o.o.c.i.r.s.internal.SitemapResource:197 - Run clean SSE subscriptions job
18:04:36.381 [OH-common-1] DEBUG o.o.c.internal.items.ExpireManager:215 - Item testGroup received no command or update for PT30S - posting command 'OFF'
18:04:36.385 [eventexecutor-1] TRACE o.o.c.internal.items.ExpireManager:144 - Received 'OFF' for item testGroup
18:04:36.385 [eventexecutor-1] DEBUG o.o.c.internal.items.ExpireManager:154 - Item testGroup received 'OFF'; stopping any future expiration.
18:04:36.386 [eventexecutor-1] TRACE o.o.c.internal.items.ExpireManager:144 - Received 'OFF' for item testSwitch

[cweitkamp]

And for the record, the above example is wrong.

Yes, that is correct. I wrote it.down in a second on my phone. All the better that you got it sorted. Thanks.

[openhab-bot]

This issue has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/grouipitem-with-expire-metadata/160635/3