Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single JSR223 script can permanently lock up all other scripts from loading #3179

Open
ccutrer opened this issue Nov 27, 2022 · 2 comments · Fixed by #3180
Open

Single JSR223 script can permanently lock up all other scripts from loading #3179

ccutrer opened this issue Nov 27, 2022 · 2 comments · Fixed by #3180
Labels
bug An unexpected problem or unintended behavior of the Core

Comments

@ccutrer
Copy link
Contributor

ccutrer commented Nov 27, 2022

Say you have a super simple script (simplified for illustration purposes; a real world example could involve an accidental deadlock, or waiting indefinitely for an external service the script calls), like this:

loop { sleep 1 }

(Yes, I shot myself in the foot doing something kind of like this trying to debug something! Luckily my condition eventually happened, so I didn't have to restart, but I realized my mistake as soon as I saved the file.)

ScriptFileWatcher loads scripts serially, so that will permanently lock up any other scripts from loading, and the only way to recover is to restart openHAB.

ccutrer added a commit to ccutrer/openhab-core that referenced this issue Nov 27, 2022
fixes openhab#3179

prevents scripts from being able to lock up ScriptFileWatcher permanently

Signed-off-by: Cody Cutrer <cody@cutrer.us>
@wborn wborn linked a pull request Nov 30, 2022 that will close this issue
ccutrer added a commit to ccutrer/openhab-core that referenced this issue Nov 30, 2022
fixes openhab#3179

prevents scripts from being able to lock up ScriptFileWatcher permanently

Signed-off-by: Cody Cutrer <cody@cutrer.us>
@wborn wborn closed this as completed in ff75505 Nov 30, 2022
@cweitkamp cweitkamp reopened this Dec 13, 2022
@cweitkamp
Copy link
Contributor

Let's reopen this to track the issue again.

@wborn wborn added the bug An unexpected problem or unintended behavior of the Core label Dec 14, 2022
@jlaur
Copy link
Contributor

jlaur commented Dec 14, 2022

For reference: #3227

splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this issue Jul 12, 2023
Fixes openhab#3179

Signed-off-by: Cody Cutrer <cody@cutrer.us>
GitOrigin-RevId: ff75505
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of the Core
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants