Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Change loading mechanism for *.things and *.items files #3235

Closed
spacemanspiff2007 opened this issue Dec 17, 2022 · 3 comments · Fixed by #4076
Closed

[RFC] Change loading mechanism for *.things and *.items files #3235

spacemanspiff2007 opened this issue Dec 17, 2022 · 3 comments · Fixed by #4076

Comments

@spacemanspiff2007
Copy link
Contributor

Currently when a file is edited all items from the file get removed and then the items from the file get re-added again.
This results in a log of items/things loosing the current state and runtime data.

A better solution would be in case of a file change to build a diff between the already existing items/things from the file.
Objects that were removed get deleted, objects that were change get changed and objects that were added can be added normally.

@jimtng
Copy link
Contributor

jimtng commented Jan 31, 2024

AFAIK, this is no longer the case in 4.x? i.e. it now leaves the unchanged items alone and their states remain unchanged?

@spacemanspiff2007
Copy link
Contributor Author

I think there was some work on the items loader so at least for *.items files this should work now. I'm unsure about the *.things files - I think it's still an issue there.

@jimtng
Copy link
Contributor

jimtng commented Feb 1, 2024

I'm unsure about the *.things files - I think it's still an issue there.

Can you try and post steps to reproduce the issue? I just did some quick tests, it seems that changes are picked up. I can confirm this. I tried with two things in one .things file, changing one's settings also caused the other one to be "updated".

I posted a PR to fix detecting changes in .items channel configuration (e.g. for profiles), hopefully that'll get merged in the next few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants