Fix change detection for textual things #4076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimtng
force-pushed
the
things-reload-fix
branch
2 times, most recently
from
9d99686 to
8a6ed12
Compare
|
@jimtng : conflicts is mentioned It would be cool to have a review of your PR. I tale a look but I am not enough aware of the code you updated to confirm that your changes are valid. |
|
Can you rebase? |
There were two problems: - The old things weren't removed, resulting in accumulation of duplicate things and comparing the new one against the old one resulting in erroneous update - Numeric values (usually entered as integer) in a newly loaded Channel Configuration properties are stored as BigDecimal with Scale 0, but subsequent normalization changed it to scale 1. This made equals() return false when it shouldn't. This leads to calling notifyListenersAboutUpdatedElement unnecessarily. Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
|
rebased |
jimtng
changed the title
|
Integration tests failed in org.openhab.core.automation.tests: |
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
|
checks passed now |
|
Looks good. |
J-N-K
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3235
General Problem Description:
When a .things file contains multiple Things and only one thing was changed, update notifications will be sent for all the things inside the file.
It should only send an update notification for the one thing that changed, and not the other things.
This is caused by two issues: