Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REST] New actions API requires localization of labels and descriptions #3303

Closed
lolodomo opened this issue Jan 8, 2023 · 3 comments · Fixed by #3337
Closed

[REST] New actions API requires localization of labels and descriptions #3303

lolodomo opened this issue Jan 8, 2023 · 3 comments · Fixed by #3337

Comments

@lolodomo
Copy link
Contributor

lolodomo commented Jan 8, 2023

The REST API returning the list of actions should localize the labels and descriptions.
This was not done in PR #2810
@lolodomo lolodomo changed the title New actions REST API requires localization of labels and descriptions [REST] New actions API requires localization of labels and descriptions Jan 8, 2023
@spacemanspiff2007
Copy link
Contributor

What would you expect openHAB to return? The language configured?
See also #3146

@lolodomo
Copy link
Contributor Author

lolodomo commented Jan 8, 2023 •
edited
Loading

I would expect the same result as for other REST endpoints, like for example channel-tyoe.

I tested again channel-type this morning in API Explorer (Main UI) and the returned labels and descriptions are in French in my case.

lolodomo added a commit to lolodomo/openhab-core that referenced this issue Jan 26, 2023
@lolodomo
[REST] Consider language when requesting thing actions
1390dca 
Fix openhab#3303

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo lolodomo mentioned this issue Jan 26, 2023
Merged
@lolodomo
Copy link
Contributor Author

lolodomo commented Jan 26, 2023 •
edited
Loading

Hopefully, the fix was really easy after checking how it is handled in other REST endpoints (like thing-types for example).

J-N-K pushed a commit that referenced this issue Jan 26, 2023
@lolodomo
[REST] Consider language when requesting thing actions (#3337)
c079f2c 
Fix #3303

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
crnjan pushed a commit to crnjan/openhab-core that referenced this issue Jan 28, 2023
@lolodomo @crnjan
[REST] Consider language when requesting thing actions (openhab#3337)
150db37 
Fix openhab#3303

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Boris Krivonog <boris.krivonog@inova.si>
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this issue Jul 12, 2023
@lolodomo @splatch
[REST] Consider language when requesting thing actions (openhab#3337)
2ff35eb 
Fix openhab#3303

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
GitOrigin-RevId: c079f2c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[REST] Consider language when requesting thing actions lolodomo/openhab-core
2 participants
@lolodomo @spacemanspiff2007