Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error downloading jackson-datatype-jdk8 causes addon installation to fail #4399

Closed
mhilbush opened this issue Oct 2, 2024 · 9 comments
Closed
Labels
bug An unexpected problem or unintended behavior of the Core

Comments

@mhilbush
Copy link
Contributor

mhilbush commented Oct 2, 2024

Error downloading mvn:com.fasterxml.jackson.datatype/jackson-datatype-jdk8/2.17.1

In the latest snapshots (4301 in my case), I'm seeing this error, which is causing the installation of all addons to fail.

I didn't see any commits that added this dependency, so maybe it is a new internal dependency of the 2.17.1 version of jackson?

@kaikreuzer @J-N-K Does this jar need to be uploaded to the repo?

@mhilbush mhilbush added the bug An unexpected problem or unintended behavior of the Core label Oct 2, 2024
@mhilbush
Copy link
Contributor Author

mhilbush commented Oct 4, 2024

Am I the only one having this problem? I've not been able to successfully install a snapshot build since 13 September due to this error.

@wborn
Copy link
Member

wborn commented Oct 5, 2024

This may be the culprit: openhab/openhab-addons#17412

@clinique
Copy link
Contributor

clinique commented Oct 5, 2024

Am I the only one having this problem? I've not been able to successfully install a snapshot build since 13 September due to this error.

No, you're not alone ;-)

@mhilbush
Copy link
Contributor Author

mhilbush commented Oct 5, 2024

@wborn Yes, I see it here. Thanks.

https://github.com/openhab/openhab-addons/pull/17412/files#diff-27cb424f3987ed4ca34b517e65d1861933b41a4c844e7ac332bcadca40e02239R11

Ah, so it only would affect people who have the mqtt binding installed, which I do.

Can someone please upload that jar to the repo? @kaikreuzer

@J-N-K
Copy link
Member

J-N-K commented Oct 5, 2024

Do we really need that bundle? I can't imagine that we really serialize/deserialize something like Optional.

@mhilbush
Copy link
Contributor Author

mhilbush commented Oct 5, 2024

I uninstalled the mqtt addon and I'm successfully running the latest snapshot. Thanks @wborn!! I don't know how I missed that PR.

@kaikreuzer
Copy link
Member

I do not know, where this dependency was introduced, but I've uploaded it to artifactory - @mhilbush please close the issue, if this issue is resolved by it.

@wborn
Copy link
Member

wborn commented Oct 5, 2024

Do we really need that bundle? I can't imagine that we really serialize/deserialize something like Optional.

I don't know if it is actually used. If it's not used the osgiified bundle osgi.bnd should define it as an optional import, see also:

openhab/openhab-addons#17509 (comment)

@mhilbush
Copy link
Contributor Author

mhilbush commented Oct 6, 2024

I confirmed the problem is resolved.

But would you prefer I leave this issue open until you determine if that dependency is required? Or do you want to open another issue for that?

@mhilbush mhilbush closed this as completed Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of the Core
Projects
None yet
Development

No branches or pull requests

5 participants