Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mqtt.homeassistant] Update Jinjava to 2.7.3 #17412

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

ccutrer
Copy link
Contributor

@ccutrer ccutrer commented Sep 12, 2024

Dependent on openhab/openhab-osgiify#51.

Closes #15145

Signed-off-by: Cody Cutrer <cody@cutrer.us>
@ccutrer ccutrer requested review from antroids, jochen314 and a team as code owners September 12, 2024 14:14
@ccutrer ccutrer added awaiting other PR Depends on another PR bug An unexpected problem or unintended behavior of an add-on labels Sep 12, 2024
@ccutrer ccutrer requested review from J-N-K and lsiepel September 12, 2024 14:14
@lsiepel lsiepel added rebuild Triggers Jenkins PR build and removed awaiting other PR Depends on another PR rebuild Triggers Jenkins PR build labels Sep 12, 2024
@lsiepel
Copy link
Contributor

lsiepel commented Sep 14, 2024

[WARNING] Error:
Error downloading mvn:org.openhab.osgiify/com.hubspot.jinjava.jinjava/2.7.3_0

@wborn wborn added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Sep 14, 2024
@lsiepel
Copy link
Contributor

lsiepel commented Sep 14, 2024

Where deos it get that artifact from? Should the osgified file be uploaded somewhere?

@ccutrer
Copy link
Contributor Author

ccutrer commented Sep 14, 2024

I have no idea. I just kind of assumed a nightly build would handle it. But it's been two nights now. @J-N-K?

@holgerfriedrich
Copy link
Member

@kaikreuzer could you please upload the latest version? Thanks!

@J-N-K
Copy link
Member

J-N-K commented Sep 15, 2024

This should work automatically once the build is triggered.

@holgerfriedrich
Copy link
Member

Do I get it correctly, https://ci.openhab.org/job/openhab-osgiify/ should upload the artifacts?

@J-N-K it seems that build 36 did not properly store to Artifactory.
I can see builds only up to 35:
https://openhab.jfrog.io/ui/builds/openhab-osgiify/?buildRepo=artifactory-build-info

@wborn wborn added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Sep 15, 2024
@lsiepel
Copy link
Contributor

lsiepel commented Sep 15, 2024

@wborn thanks, seems you fixed it. For future changes, do you need to trigger that ci build manually (liike a release/milestone), or should this build and upload ci trigger automatically after merge?

@J-N-K
Copy link
Member

J-N-K commented Sep 15, 2024

It's a manual build.

@wborn
Copy link
Member

wborn commented Sep 15, 2024

I upgraded the Jenkins Artifactory plugin to fix it. I downgraded it earlier to see if it would fix the other issue but it didn't help.

When I find some time I'll try to replace it with the Artifactory Maven plugin which can also be used to upload artifacts in GitHub Actions builds.

@jimtng
Copy link
Contributor

jimtng commented Sep 16, 2024

Signed-off-by: Cody Cutrer <cody@cutrer.us>
@lsiepel
Copy link
Contributor

lsiepel commented Sep 17, 2024

Almost there. Some dependency’s are missing

@ccutrer
Copy link
Contributor Author

ccutrer commented Sep 18, 2024

Omg, there it is! 2.7.3 added the following new dependencies:

  • com.fasterxml.jackson.datatype » jackson-datatype-jdk8
  • com.hubspot.immutables » immutable-exceptions

Thank you for pointing it out! Now to figure out how to add dependencies...

Signed-off-by: Cody Cutrer <cody@cutrer.us>
@ccutrer
Copy link
Contributor Author

ccutrer commented Sep 18, 2024

openhab/openhab-osgiify#53 needs merged and pushed to the openhab repo first. After that, I ran a full verify build including itests for MQTT and Jinja Transformation locally, and everything passed. 🤞

@ccutrer
Copy link
Contributor Author

ccutrer commented Sep 22, 2024

Woohoo! Build passed!

@holgerfriedrich holgerfriedrich added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Sep 22, 2024
@lsiepel lsiepel merged commit bcfbd64 into openhab:main Sep 23, 2024
5 checks passed
@lsiepel lsiepel added this to the 4.3 milestone Sep 23, 2024
@ccutrer ccutrer deleted the mqtt-homeassistant-jinjava-2.7.3 branch September 23, 2024 16:23
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
* [mqtt.homeassistant] Update Jinjava to 2.7.3

Signed-off-by: Cody Cutrer <cody@cutrer.us>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
* [mqtt.homeassistant] Update Jinjava to 2.7.3

Signed-off-by: Cody Cutrer <cody@cutrer.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[mqtt.homeassistant][JINJA] Transformation problem with value template key
6 participants