-
-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resource leak: audio manager #532
Comments
@kaikreuzer Should we mark resource leaks with a "critical" label? |
It depends whether we consider it critical ;-)
I am personally using |
For me it is different. If a productive system fails because it runs out of resources, it could be hard to find the root cause (network traffic, files, ...). In the special case the input stream of an On my working machine it fails on the "1023268" try to open an file input stream without closing it. ... but openHAB Core as a framework should not matter about its usage and do its best to be flexible and "safe" (what a magic word) to use. So, okay if you don't want to mark that one as critical -- for me it stays on the list of critical issues (as soon as I start to use the audio support). 😉 |
I think it is not handled correctly anymore. But currently we do not face a resource leak because of two things.
Latest Apache Commons IO 2.6 API removed the Do you think we should /could update Apache Commons IO dependency too? We include version 2.2.0. What are the plans for it? |
There are other things I don't understand. Perhaps you can give me some more information: The The current implementation of the |
@kaikreuzer friendly ping |
This is the
This is then clearly a bug that should be fixed. |
If my understanding of the audio managers
playFile
implementation is correct then there is a resource leak.At least for me it seems that the input stream if not closed reliable (if at all).
The text was updated successfully, but these errors were encountered: