audio servlet: don't change map while used by interation #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should not remove entries (so keys) from the map while we are using the key set (a view) of that map (see JavaDoc: otherwise "results of the iteration undefined"). Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
cweitkamp
reviewed
May 7, 2019
| // the stream has expired, we need to remove it! | ||
| final FixedLengthAudioStream stream = multiTimeStreams.remove(streamId); | ||
| streamTimeouts.remove(streamId); | ||
| IOUtils.closeQuietly(stream); |
There was a problem hiding this comment.
@maggu2810 I think in this line you can find a piece of the puzzle to answer #532.
There was a problem hiding this comment.
Not really. While reading this implementation there are much more things that confused me. I answered to #532
Rosi2143
pushed a commit
to Rosi2143/openhab-core
that referenced
this pull request
Dec 26, 2020
Signed-off-by: Patrick Fink <mail@pfink.de>
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not remove entries (so keys) from the map while we are using the key set (a view) of that map (see JavaDoc: otherwise "results of the iteration undefined").