[i18n] Refactoring and annotations

[cweitkamp]

• Moved i18n util classes into internal packages
• Use ConfigI18nLocalizationService instead of ConfigDescriptionI18nUtil in other packages than o.o.c.config.*
• Refactoring of automation i18n util classes according our default implementation for these util classes (e.g. non static)
• Added nullness annotations for i18n util classes

Signed-off-by: Christoph Weitkamp github@christophweitkamp.de

[wborn]

Thanks! Setting the TranslationProvider using the constructor in the utility classes helps a lot with reducing the number of method parameters and simplifying the code.

Did you also consider creating components out of those utility classes (ModuleI18nUtil, ModuleTypeI18nUtil, RuleTemplateI18nUtil)? It might make the classes using those Util classes easier to unit test when instead of the Util classes some Mocks can be injected.

I also have one small comment below.

[cweitkamp]

Did you also consider creating components out of those utility classes

No, I did not. We have different i18n services / components which should be used by other bundles if they need localized entities. My understandig of those utility classes is that they are internal and only be used by the i18n services itself as singleton object - more or less to reduce lines of code / to source out the code for better maintainability of the i18n services.

[wborn]

LGTM now!