Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed 1.x compatibility layer #1284

Merged
merged 1 commit into from
Dec 21, 2019
Merged

removed 1.x compatibility layer #1284

merged 1 commit into from
Dec 21, 2019

Conversation

kaikreuzer
Copy link
Member

@kaikreuzer
removed 1.x compatibility layer
55937b4 
Signed-off-by: Kai Kreuzer <kai@openhab.org>
wborn
wborn approved these changes Dec 21, 2019
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I double checked with some grepping and looks like you found all references.

Deleting 10KLOC is pretty significant too and illustrates how much code and effort goes into maintaining this.

@wborn wborn merged commit 650f895 into openhab:master Dec 21, 2019
@kaikreuzer
Copy link
Member Author

Thanks for merging :-)

@kaikreuzer kaikreuzer deleted the removecompat branch December 21, 2019 10:32
@cweitkamp cweitkamp mentioned this pull request Dec 22, 2019
Merged
wborn added a commit to wborn/openhab-distro that referenced this pull request Dec 22, 2019
@wborn
Remove OH1 add-ons
ff2593c 
OH3 no longer has the OH1 compatibility layer so it shouldn't package or support such add-ons.

Related to: openhab/openhab-core#1284

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn mentioned this pull request Dec 22, 2019
Merged
wborn added a commit to wborn/openhab-distro that referenced this pull request Dec 22, 2019
@wborn
Remove OH1 add-ons
33b9d28 
OH3 no longer has the OH1 compatibility layer so it shouldn't package or support such add-ons.

Related to: openhab/openhab-core#1284

Signed-off-by: Wouter Born <github@maindrain.net>
kaikreuzer pushed a commit to openhab/openhab-distro that referenced this pull request Dec 23, 2019
@wborn @kaikreuzer
Remove OH1 add-ons (#1026)
e33982f 
OH3 no longer has the OH1 compatibility layer so it shouldn't package or support such add-ons.

Related to: openhab/openhab-core#1284

Signed-off-by: Wouter Born <github@maindrain.net>
@kaikreuzer kaikreuzer mentioned this pull request Dec 29, 2019
Closed
@cweitkamp cweitkamp added this to the 3.0 milestone Dec 31, 2019
@cweitkamp cweitkamp added API breaking enhancement An enhancement or new feature of the Core infrastructure and removed enhancement An enhancement or new feature of the Core labels Dec 31, 2019
@cweitkamp cweitkamp mentioned this pull request Jan 14, 2020
Closed
@5iver 5iver mentioned this pull request Jun 28, 2020
Closed
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 11, 2023
@kaikreuzer @splatch
removed 1.x compatibility layer (openhab#1284)
4fc9272 
Signed-off-by: Kai Kreuzer <kai@openhab.org>
GitOrigin-RevId: 650f895
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wborn wborn wborn approved these changes

Assignees
No one assigned
Labels
API breaking infrastructure
Projects
None yet
Milestone
3.0.0.M1
Development

Successfully merging this pull request may close these issues.
3 participants
@kaikreuzer @wborn @cweitkamp