Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced Joda Time by Java Time #1342

Merged
merged 4 commits into from
Jan 25, 2020
Merged

replaced Joda Time by Java Time #1342

merged 4 commits into from
Jan 25, 2020

Conversation

kaikreuzer
Copy link
Member

@kaikreuzer kaikreuzer commented Jan 25, 2020

This PR finally gets rid off Joda Time.
As discussed in the past, this will break rules from users, but as the final rule format is anyhow still under discussion, it is clear that we will need some way or another for rule migration for the 3.0 release. This PR should hence not really have much additional weight.

Signed-off-by: Kai Kreuzer kai@openhab.org

Fixes #1250

Signed-off-by: Kai Kreuzer <kai@openhab.org>
@kaikreuzer kaikreuzer requested a review from a team January 25, 2020 20:02
Signed-off-by: Kai Kreuzer <kai@openhab.org>
Signed-off-by: Kai Kreuzer <kai@openhab.org>
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! 👍 I also had this on my short term TODO list. :-)

@kaikreuzer
Copy link
Member Author

It wasn't on mine, I only was reminded here that Joda is still around and I thought it is really time to do something about it 😉.

@kaikreuzer
Copy link
Member Author

I just have to get the tests working again...

Signed-off-by: Kai Kreuzer <kai@openhab.org>
@kaikreuzer
Copy link
Member Author

Allo green 😅 .

@meingraham
Copy link

😬 I agree that Joda time is a pain... but I have it coded in many, many rules. I can't bear to think about troubleshooting all my rules to get the new syntax right. I can't say I disagree with this move... but I'm not looking forward to migrating.

@wborn wborn merged commit 86899da into openhab:master Jan 25, 2020
@5iver
Copy link

5iver commented Jan 26, 2020

Are you planning another PR for the documentation or should that wait until the direction for automation has been finalized?

@kaikreuzer kaikreuzer deleted the joda branch January 26, 2020 10:11
@kaikreuzer
Copy link
Member Author

No, not planning a docs PR as there'll be many more changes to rules and we anyhow first need to address openhab/openhab-docs#1133.

@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/guide-binding-development-changes-for-openhab-3-from-2-5-x/104134/4

Rosi2143 pushed a commit to Rosi2143/openhab-core that referenced this pull request Dec 26, 2020
Signed-off-by: Kai Kreuzer <kai@openhab.org>
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 11, 2023
* replaced Joda Time by Java Time

Signed-off-by: Kai Kreuzer <kai@openhab.org>

* removed joda from target platform feature

Signed-off-by: Kai Kreuzer <kai@openhab.org>

* updated tests

Signed-off-by: Kai Kreuzer <kai@openhab.org>

* fixed persistence extension tests

Signed-off-by: Kai Kreuzer <kai@openhab.org>
GitOrigin-RevId: 86899da
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace org.joda.time with java.time and drop Joda-Time support
6 participants