[ephemeris] isBankHoliday(offset, filename) now really uses the filename #1375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RolandRosenfeld
force-pushed
the
1374-isBankHolidayFilename
branch
from
5380c15
to
941b197
Compare
Closes: openhab#1374 Signed-off-by: Roland Rosenfeld <roland@debian.org>
RolandRosenfeld
force-pushed
the
1374-isBankHolidayFilename
branch
from
941b197
to
64e2114
Compare
cweitkamp
approved these changes
Feb 24, 2020
cweitkamp
changed the title
Rosi2143
pushed a commit
to Rosi2143/openhab-core
that referenced
this pull request
Dec 26, 2020
Signed-off-by: Rich Koshak <rlkoshak@gmail.com> (github: rkoshak)
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 11, 2023
…ame (openhab#1375) Closes: openhab#1374 Signed-off-by: Roland Rosenfeld <roland@debian.org> GitOrigin-RevId: 730a8e1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isBankHoliday(offset, filename) in 2.5.0 and master throws away the filename instead of using it. This little patch should fix this.
Closes: #1374