[automation] Use UTF-8 to read files

[cweitkamp]

• Use UTF-8 to read files

Otherwise I am seeing e.g. such log messages:

2020-05-19 14:37:56.639 [INFO ] [ipse.smarthome.model.script.presence] - Trigger für presenceChristophPresent changed from OFF to ON ...

Or wrong tags:

        "tags": [
            "Anwesenheit",
            "Küche"
        ],

Signed-off-by: Christoph Weitkamp github@christophweitkamp.de

[5iver]

I've never noticed this. What script language were you using?

I have not tested it, but everything looks good to me. However, there is a lot more than just UTF-8 changes in there! 🙂

[cweitkamp]

I am using Python combined with the helper libraries.

[5iver]

Are you using unicode strings? I have a pile of updates for the helper libraries and one of them is using unicode for all of the core libraries.

[cweitkamp]

automation/jsr223/python/personal/presence.py: Python script, UTF-8 Unicode text executable

[wborn]

Thanks!

[5iver]

@cweitkamp, I have tested this and I did not see any difference in functionality. Do you have a before/after test to show that this change is doing something?

Edit... I took another peak. Wouldn't the Charset for InputStreamReader defaulted to UTF-8, so specifying it wouldn't actually be changing anything?

[openhab-bot]

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/no-international-characters-unicode-with-jsr223-jython/99567/9

[openhab-bot]

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/no-international-characters-unicode-with-jsr223-jython/99567/10

[cweitkamp]

IIRC InputStreamReader defaults to system default charset - which might not always be UTF-8. Specifying it does not hurt as we try to keep it aligned throughout the framework.

I learned of this community post that OHC is not the real problem but encoding used by current Python / Jython version. For me masking a String via u"..." in my rules and saving the files with UTF-8 encoding is a working solution.