Removed deprecated constructors and methods #1500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
cweitkamp
added
awaiting other PR
wborn
approved these changes
May 24, 2020
There was a problem hiding this comment.
The changes look good to me. The removal of the Calendar constructor/method in the DateTimeType can have a big impact on existing rules. Do you think we should remove it in OH3 @kaikreuzer? It has been marked as deprecated for years now. It was deprecated in eclipse-archived/smarthome#4259.
|
Friendly ping @kaikreuzer . |
kaikreuzer
approved these changes
Jun 13, 2020
There was a problem hiding this comment.
Thanks for the ping, I didn't see your question @wborn.
I am all for removing the constructor - as you say, it is marked deprecated since a long time and when if not now should we remove it?
|
Seems this broke the addons build, see https://ci.openhab.org/job/openHAB-Addons-port/158/console: |
|
I will take care of that. |
|
I submitted a rough fix for openHAB add-ons (openhab/openhab-addons#7918). |
|
Thanks @cweitkamp! Wow, those are more occurrences than I had imagined 🤔. |
wborn
added a commit
to wborn/openhab-addons
that referenced
this pull request
Jun 20, 2020
Related to: * openhab/openhab-core#1500 * openhab#7918 Signed-off-by: Wouter Born <github@maindrain.net>
cweitkamp
pushed a commit
to openhab/openhab-addons
that referenced
this pull request
Jun 20, 2020
Related to: * openhab/openhab-core#1500 * #7918 Signed-off-by: Wouter Born <github@maindrain.net>
knikhilwiz
pushed a commit
to knikhilwiz/openhab2-addons
that referenced
this pull request
Jul 12, 2020
Related to: * openhab/openhab-core#1500 * openhab#7918 Signed-off-by: Wouter Born <github@maindrain.net>
CSchlipp
pushed a commit
to CSchlipp/openhab-addons
that referenced
this pull request
Jul 26, 2020
Related to: * openhab/openhab-core#1500 * openhab#7918 Signed-off-by: Wouter Born <github@maindrain.net> Signed-off-by: CSchlipp <christian@schlipp.de>
MPH80
pushed a commit
to MPH80/openhab-addons
that referenced
this pull request
Aug 3, 2020
Related to: * openhab/openhab-core#1500 * openhab#7918 Signed-off-by: Wouter Born <github@maindrain.net> Signed-off-by: MPH80 <michael@hazelden.me>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
Related to: * openhab/openhab-core#1500 * openhab#7918 Signed-off-by: Wouter Born <github@maindrain.net>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
Related to: * openhab/openhab-core#1500 * openhab#7918 Signed-off-by: Wouter Born <github@maindrain.net>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
Related to: * openhab/openhab-core#1500 * openhab#7918 Signed-off-by: Wouter Born <github@maindrain.net>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
Related to: * openhab/openhab-core#1500 * openhab#7918 Signed-off-by: Wouter Born <github@maindrain.net>
DaanMeijer
pushed a commit
to DaanMeijer/openhab-addons
that referenced
this pull request
Sep 1, 2020
Related to: * openhab/openhab-core#1500 * openhab#7918 Signed-off-by: Wouter Born <github@maindrain.net> Signed-off-by: Daan Meijer <daan@studioseptember.nl>
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
Sep 19, 2020
Related to: * openhab/openhab-core#1500 * openhab#7918 Signed-off-by: Wouter Born <github@maindrain.net>
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 11, 2023
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> GitOrigin-RevId: 1fddac1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1408
Signed-off-by: Christoph Weitkamp github@christophweitkamp.de
Depends on openhab/openhab-addons#7766