Added group and system triggers to automation component #1509
Conversation
Signed-off-by: Kai Kreuzer <kai@openhab.org>
...ain/java/org/openhab/core/automation/internal/module/handler/GroupCommandTriggerHandler.java
Outdated
Show resolved
Hide resolved
...ain/java/org/openhab/core/automation/internal/module/handler/GroupCommandTriggerHandler.java
Show resolved
Hide resolved
...ain/java/org/openhab/core/automation/internal/module/handler/GroupCommandTriggerHandler.java
Outdated
Show resolved
Hide resolved
...ain/java/org/openhab/core/automation/internal/module/handler/GroupCommandTriggerHandler.java
Outdated
Show resolved
Hide resolved
.../main/java/org/openhab/core/automation/internal/module/handler/GroupStateTriggerHandler.java
Outdated
Show resolved
Hide resolved
| "description": "the received command", | ||
| "required": false, | ||
| "limitToOptions": false, | ||
| "options": [ |
There was a problem hiding this comment.
What about other Commands (e.g. PLAY, PAUSE, etc.)?
There was a problem hiding this comment.
Might become a rather long list - I did it the same way here as we have it for all the other item triggers, so this is in line. It can be discussed whether only the most frequently used commands should be listed or all enum types, but this can be done in a separate PR if needed.
There was a problem hiding this comment.
Yes, I know. Does it make sense to add / introduce a "context": "command" for these options? Then is can be handled globally?
There was a problem hiding this comment.
Might be an option, but it would possibly shift the implementation work to the UIs then.
I would wait and see how it is really used in daily life and what we feel is missing and should be changed. I don't have a clear view on it yet.
...g.openhab.core.automation/src/main/resources/OH-INF/automation/moduletypes/ItemTriggers.json
Show resolved
Hide resolved
bundles/org.openhab.core/src/main/java/org/openhab/core/events/system/SystemEventFactory.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/openhab/core/automation/internal/module/handler/SystemTriggerHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Kai Kreuzer <kai@openhab.org>
|
Thanks @cweitkamp, I have addressed your comments. |
bundles/org.openhab.core/src/main/java/org/openhab/core/events/system/StartlevelEvent.java
Show resolved
Hide resolved
.../main/java/org/openhab/core/automation/internal/module/handler/GroupStateTriggerHandler.java
Outdated
Show resolved
Hide resolved
.../main/java/org/openhab/core/automation/internal/module/handler/GroupStateTriggerHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Kai Kreuzer <kai@openhab.org>
|
Thanks again, @cweitkamp, everything should be addressed now! |
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/jython-when-item-added-removed-modified-not-working/100994/4 |
…penhab#1509) * Added group and system triggers to automation component Signed-off-by: Kai Kreuzer <kai@openhab.org> GitOrigin-RevId: d265e16
This PR completes the automation component to provide the same triggers as the "old" rule engine. It thus specifically adds modules for "member of group" triggers as well as a start level trigger, which can be used to run rules once at system startup (disclaimer: No start level events are defined in this PR yet, so the trigger itself is still rather useless).
This was part of #1451 and has been separated as an independent PR that can already been reviewed and merged independently.
Signed-off-by: Kai Kreuzer kai@openhab.org