[REST] Added validation for relation between ThingUID and BridgeUID #1704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cweitkamp
added
bug
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
cweitkamp
force-pushed
the
bugfix-rest-thinguid-bridgeuid
branch
from
c90d310
to
47beed1
Compare
kaikreuzer
added
rebuild
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ThingUIDwhen creating aThingwhich is related to aBridgeSimilar to #1481
My first idea was to add the check inside ThingRegistryImpl.createThingOfType(ThingTypeUID, ThingUID, ThingUID, String, Configuration) but I was not sure if it is the best idea to throw an IAE if the given
ThingUIDdoes not match as it will be API breaking.Maybe we should not merge it until we have a valid solution for openhab/openhab-webui#380.
Signed-off-by: Christoph Weitkamp github@christophweitkamp.de