-
-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Automation extension type #1722
Conversation
Signed-off-by: Wouter Born <github@maindrain.net>
Heads up, this has implications for the UI, docs processing, and website :) |
I added this type as per openhab/openhab-addons#7208 (comment). My JSR223 Groovy scripts didn't work after adding the Groovy JARs to |
It's a valuable addition for sure, just reminding that this would probably lead to dependent PRs merged in the proper order ;) |
That's the part where I thought it would break 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Imho much better than having it all under "Misc" - so assuming @ghys and @Confectrician will help adapting UI and docs/website, let's merge it 👍 .
I'm looking forward to see what kind of icon @ghys comes up with for this one. 😉 |
Browsed the entire list of icons twice now. 😄 I think the best option is to go with this one: Provided we also replace the "Rules" icons from wand_rays to wand_stars: The stars could be a reference to "magic", i.e. automation...? As for the blurb below maybe: "Scripting languages and module types for rules" or similar? |
I'm fine with that as it indeed does make sense that you need to apply sparkles with a wand. :-) |
Go for it! |
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/how-to-setup-jython/53049/172 |
* Add automation type * Sort content * Replace freetts Related to openhab/openhab-core#1722 Signed-off-by: Wouter Born <github@maindrain.net>
* Add automation type * Sort content * Replace freetts Related to openhab/openhab-core#1722 Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: Wouter Born <github@maindrain.net> GitOrigin-RevId: 605c1c2
This type allows for installing automation add-ons such as: