Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Automation extension type #1722

Merged
merged 1 commit into from
Oct 17, 2020
Merged

Conversation

wborn
Copy link
Member

@wborn wborn commented Oct 16, 2020

This type allows for installing automation add-ons such as:

Signed-off-by: Wouter Born <github@maindrain.net>
@ghys
Copy link
Member

ghys commented Oct 16, 2020

Heads up, this has implications for the UI, docs processing, and website :)

@wborn
Copy link
Member Author

wborn commented Oct 16, 2020

I added this type as per openhab/openhab-addons#7208 (comment).

My JSR223 Groovy scripts didn't work after adding the Groovy JARs to /runtime/lib/ext so I thought let's see if it is easy to create an add-on instead. That only took a couple of hours, so it was easier than expected and can now be removed from my TODO list. 😉

@ghys
Copy link
Member

ghys commented Oct 16, 2020

It's a valuable addition for sure, just reminding that this would probably lead to dependent PRs merged in the proper order ;)

@wborn
Copy link
Member Author

wborn commented Oct 16, 2020

Yes it does result in some more work.

The UI already works well except for that it looks a bit bland:

Screenshot from 2020-10-16 23-23-03

Screenshot from 2020-10-16 23-28-30

@ghys
Copy link
Member

ghys commented Oct 16, 2020

That's the part where I thought it would break 😄

@wborn wborn added rebuild Triggers the Jenkins PR build automation karaf and removed rebuild Triggers the Jenkins PR build labels Oct 17, 2020
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imho much better than having it all under "Misc" - so assuming @ghys and @Confectrician will help adapting UI and docs/website, let's merge it 👍 .

@kaikreuzer kaikreuzer merged commit 605c1c2 into openhab:master Oct 17, 2020
@wborn wborn deleted the add-automation branch October 17, 2020 13:15
@wborn
Copy link
Member Author

wborn commented Oct 17, 2020

I'm looking forward to see what kind of icon @ghys comes up with for this one. 😉

@ghys
Copy link
Member

ghys commented Oct 17, 2020

Browsed the entire list of icons twice now. 😄

I think the best option is to go with this one:
image

Provided we also replace the "Rules" icons from wand_rays to wand_stars:
image

The stars could be a reference to "magic", i.e. automation...?

As for the blurb below maybe: "Scripting languages and module types for rules" or similar?
image

@wborn
Copy link
Member Author

wborn commented Oct 17, 2020

I'm fine with that as it indeed does make sense that you need to apply sparkles with a wand. :-)

@kaikreuzer
Copy link
Member

Go for it!

@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/how-to-setup-jython/53049/172

wborn added a commit to wborn/openhab-distro that referenced this pull request Oct 18, 2020
* Add automation type
* Sort content
* Replace freetts

Related to openhab/openhab-core#1722

Signed-off-by: Wouter Born <github@maindrain.net>
kaikreuzer pushed a commit to openhab/openhab-distro that referenced this pull request Oct 18, 2020
* Add automation type
* Sort content
* Replace freetts

Related to openhab/openhab-core#1722

Signed-off-by: Wouter Born <github@maindrain.net>
@kaikreuzer kaikreuzer added this to the 3.0.0.M2 milestone Nov 2, 2020
@kaikreuzer kaikreuzer added the enhancement An enhancement or new feature of the Core label Nov 2, 2020
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 11, 2023
Signed-off-by: Wouter Born <github@maindrain.net>
GitOrigin-RevId: 605c1c2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation enhancement An enhancement or new feature of the Core karaf
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants