[automation] Extracted accessor into interface and added to script engine context … #1843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to allow access to script extensions from script engine factories Signed-off-by: Jonathan Gilbert <jpg@trillica.com>
jpg0
changed the title
|
I've now tested this with both existing (groovy) and new (graaljs) and it all looks good, so I'll take out of draft. |
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 11, 2023
…to allow access to script extensions from script engine factories (openhab#1843) Signed-off-by: Jonathan Gilbert <jpg@trillica.com> GitOrigin-RevId: e8d017d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…to allow access to script extensions from script engine factories
This is to allow script engines the ability to reference extensions (via the script context). Note that I have called the methods
findXrather thangetXbecausegetDefaultPresetsalready exists, yet returns the preset names, not the presets themselves.(I will move out of draft once I've finished testing.)
Signed-off-by: Jonathan Gilbert jpg@trillica.com