Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed NPE in ScriptError if INode is empty #1985

Merged
merged 1 commit into from
Dec 22, 2020

Conversation

cweitkamp
Copy link
Contributor

  • Fixed NPE in ScriptError if INode is empty

This will at lest show the message without referencing line and column.

See https://community.openhab.org/t/openhab-3-0-release-discussion/110751/16

Signed-off-by: Christoph Weitkamp github@christophweitkamp.de

@cweitkamp cweitkamp added bug An unexpected problem or unintended behavior of the Core DSL Domain-Specific Language labels Dec 22, 2020
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@kaikreuzer kaikreuzer merged commit 7ce96ac into openhab:master Dec 22, 2020
@cweitkamp cweitkamp deleted the bugfix-NPE branch December 22, 2020 19:34
@kaikreuzer kaikreuzer added this to the 3.1 milestone Dec 22, 2020
@cweitkamp cweitkamp added the patch A PR that has been cherry-picked to a patch release branch label Jan 16, 2021
cweitkamp added a commit that referenced this pull request Jan 16, 2021
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 11, 2023
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
GitOrigin-RevId: 7ce96ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of the Core DSL Domain-Specific Language patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants