[automation] Cache parsed script in order to improve performance #2057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kai Kreuzer <kai@openhab.org>
kaikreuzer
added
enhancement
This was referenced Jan 2, 2021
kaikreuzer
added
rebuild
wborn
approved these changes
Jan 3, 2021
|
I can't seem to find this PR in the list of fixes for 3.0.1. Does that mean we will have to either switch to snapshots or wait for the next milestone to get it? It's kinda critical for my system. |
kaikreuzer
added a commit
that referenced
this pull request
Jan 27, 2021
Signed-off-by: Kai Kreuzer <kai@openhab.org>
kaikreuzer
added
the
patch
|
@DanielMalmgren Added. 3.0.1 is not yet announced, unfortunately, there were some issues during the build. |
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 11, 2023
Signed-off-by: Kai Kreuzer <kai@openhab.org> GitOrigin-RevId: 531a478
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we have a dedicated DSLScriptEngine instance per rule script action, we can easily cache the parsed script.
Parsing seems to cause significant CPU and memory usage - with this PR, there is no noticeable CPU activity anymore and also the heap size does not increase over time anymore.
Fixes #1877
Fixes #2031
Signed-off-by: Kai Kreuzer kai@openhab.org