Added getPoolNames method to ThreadPoolManager #2065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert Bach <openhab@mortalsilence.net>
wborn
added
rebuild
kaikreuzer
approved these changes
Jan 5, 2021
kaikreuzer
changed the title
I've got a working prototype, right now refactoring it to be published as PR. I'll announce it in the forum. Thanks for the merge 👍 |
Please note that it must not be done as a binding, though. Exposing openHAB for Prometheus probably best qualifies as an I/O add-on. Please also note #774, which would be the preferred way of implementation (i.e. by using the MicroProfile API). |
This was referenced Jan 6, 2021
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 11, 2023
Signed-off-by: Robert Bach <openhab@mortalsilence.net> GitOrigin-RevId: 75f52ac
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new getPoolNames method to ThreadPoolManager in order to iterate over all thread pools. The intention is to extract metrics for a new Prometheus exporter binding I've got in the works.
Signed-off-by: Robert Bach openhab@mortalsilence.net (github: pravussum)