Add category for system channel type 'power' #2069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stem channe type 'low-battery' Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
kaikreuzer
reviewed
Jan 5, 2021
| @@ -77,7 +77,7 @@ | |||
| * on (low battery) and off (battery ok). | |||
| */ | |||
| public static final ChannelType SYSTEM_CHANNEL_LOW_BATTERY = ChannelTypeBuilder | |||
| .state(new ChannelTypeUID(BINDING_ID, "low-battery"), "Low Battery", "Switch").withCategory("Battery") | |||
| .state(new ChannelTypeUID(BINDING_ID, "low-battery"), "Low Battery", "Switch").withCategory("LowBattery") | |||
There was a problem hiding this comment.
How did it happen that we have a lowbattery property besides batterylevel? That does not make much sense to me - the property that is measured is in both cases the batterylevel - just the purpose is a different one.
The category is only used for the icons, though, right? So as an icon for that channel type, that is ok to use, so nothing against this PR.
There was a problem hiding this comment.
Sry, I do not understand. Are you talking about the default system channel types? If so I cannot give you a proper answer. They probably have been introduced before my openHAB start. 😉
There was a problem hiding this comment.
And yes, the main purpose of categories is to render the icons. Which looks a little bit out-dated next to UoM and Semantics. Might be worth to rethink them.
There was a problem hiding this comment.
All fine, I think I was rather talking to myself ;-)
kaikreuzer
approved these changes
Jan 5, 2021
cweitkamp
added a commit
to cweitkamp/openhab-docs
that referenced
this pull request
Jan 26, 2021
Related to openhab/openhab-core#2069 Related to openhab/openhab-core#2157 Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Confectrician
pushed a commit
to openhab/openhab-docs
that referenced
this pull request
Jan 27, 2021
Related to openhab/openhab-core#2069 Related to openhab/openhab-core#2157 Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
ghys
pushed a commit
to openhab/openhab-docs
that referenced
this pull request
Jan 29, 2021
* Apply bulk automated corrections. 🔧(#1433) Signed-off-by: Jerome Luckenbach <github@luckenba.ch> * Added sidebar links. (#1434) * Added sidebar links. * Introduce openhabian placeholder page. * Remove local version of openhabian doc page. Signed-off-by: Jerome Luckenbach <github@luckenba.ch> * Fix linter errors 🔧(#1435) * Fix errros for the addon folder. * Fix errros for the administration folder. * Fix errros for the concepts folder. * Fix errros for the configuration folder. * Improved and synced markdown linting rules. Signed-off-by: Jerome Luckenbach <github@luckenba.ch> * Revert #1428 (#1436) Signed-off-by: Jerome Luckenbach <github@luckenba.ch> * Fix linter errors. 🔧(#1437) Signed-off-by: Jerome Luckenbach <github@luckenba.ch> * Bulk edit linter errors. (#1438) * Bulk edit linter errors. Signed-off-by: Jerome Luckenbach <github@luckenba.ch> * Fix linter style Signed-off-by: Jerome Luckenbach <github@luckenba.ch> * Fix linter errors (#1439) * Some leftover linting error fixes. * Adapt rules and enble markdownlint for pull requests. Signed-off-by: Jerome Luckenbach <github@luckenba.ch> * Fix markdownlint workflow Signed-off-by: Jerome Luckenbach <github@luckenba.ch> * Fixes for linter errors and markdown configuration. (#1440) Signed-off-by: Jerome Luckenbach <github@luckenba.ch> * Update guidelines.md (#1441) Only a maintainer told me how to tackle a DTO properly as a class. As I did not see this anywhere, I decide to make this change. * Add fixes from markdownlint-cli (#1442) Signed-off-by: Jerome Luckenbach <github@luckenba.ch> * Switch to markdown cli action (#1443) * Fix left markdownlint errors. Signed-off-by: Jerome Luckenbach <github@luckenba.ch> * Change to markdownlint-cli action. Signed-off-by: Jerome Luckenbach <github@luckenba.ch> * Update markdownlint.yml Signed-off-by: Jerome Luckenbach <github@luckenba.ch> * Move trigger order Signed-off-by: Jerome Luckenbach <github@luckenba.ch> * Make pr check available for markdownlint 📝 (#1446) * Make pr check available for markdownlint (hopefully). Signed-off-by: Jerome Luckenbach <github@luckenba.ch> * Add link check action. (#1449) * Add link check action. Signed-off-by: Jerome Luckenbach <github@luckenba.ch> * Add blank line. Signed-off-by: Jerome Luckenbach <github@luckenba.ch> * Replace local urls with inline code. Change one occurence to openhabian. (#1450) Signed-off-by: Jerome Luckenbach <github@luckenba.ch> * remove uncessary instructions f. contribution guide (#1454) * Update items.md (#1455) Example with item Switch Kitchen_Light in the example is not correct for current binding version. * Created API token docs (#1453) * Created API token docs Signed-off-by: Gerwin Lammers <gerwinlammers@gmail.com> * Update after review session Signed-off-by: Gerwin Lammers <gerwinlammers@gmail.com> * Add new page to sidebar navigation. Signed-off-by: Jerome Luckenbach <github@luckenba.ch> Co-authored-by: Jerome Luckenbach <github@luckenba.ch> * Update rules-dsl.md (#1456) * Update rules-dsl.md Corrected the "system started" section to reflect that the trigger will no longer execute on loading the rules file in OH v.3. * Adapt inline codeblock design. Signed-off-by: Jerome Luckenbach <github@luckenba.ch> Co-authored-by: Jerome Luckenbach <github@luckenba.ch> * Remove paper ui references. (#1457) * Remove paper uii references. Signed-off-by: Jerome Luckenbach <github@luckenba.ch> * Fix Markdown errors. Signed-off-by: Jerome Luckenbach <github@luckenba.ch> * Remove target param from markdownlint pr trigger. Signed-off-by: Jerome Luckenbach <github@luckenba.ch> * Update items.md (#1458) There is one comma too much in the sample for profile hysteresis. The profile must be related to the channel. The comma will lead also to an error message in log. Switch Low_Battery { channel="serialbutton:button:mybutton:battery-level" [profile="hysteresis", lower=15, inverted=true] } * Remove cronmaker since it doesn't support HTTPS (#1459) 1. When trying to reach https://www.cronmaker.com/ the website refuses the connection. You can only reach it using HTTP (without HTTPS). You could leave cronmaker in there but I think leading users to web pages that aren't using HTTPS might be not be best idea. 2. Fix Typo in url for quartz-scheduler.org * Update links to target "main" branches (#1460) * Update links to target "main" branches Signed-off-by: Wouter Born <github@maindrain.net> * Update process_file.rb Signed-off-by: Wouter Born <github@maindrain.net> * Update for all other repos too Signed-off-by: Wouter Born <github@maindrain.net> * Add hint that /etc/default/openhab2 is not considered by the upgrade (#1461) * Add hint that /etc/default/openhab2 is not considered by the upgrade When you use a raspberry you may have used the file /etc/default/openhab2 to changed JAVA options. After upgrade to openHAB 3.0 this file is no longer used. Instead the file /etc/default/openhab must be used. * Small modifications to original pull request. Signed-off-by: Jerome Luckenbach <github@luckenba.ch> Co-authored-by: Jerome Luckenbach <github@luckenba.ch> * Fix typo in restdocs (#1463) * Update rules-dsl.md (#1465) Updated the rule example "Start wake up light on sunrise" to use the new formatting of the receivedEvent implicit variable * Update list of system default channel types (#1467) Related to openhab/openhab-core#2069 Related to openhab/openhab-core#2157 Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Delete habpanel.md (#1471) * Delete habpanel.md This file is gathered from its code repository for a long time already. Signed-off-by: Jerome Luckenbach <github@luckenba.ch> * Add habpanel placeholder for preview Signed-off-by: Jerome Luckenbach <github@luckenba.ch> Co-authored-by: coop-git <65073745+coop-git@users.noreply.github.com> Co-authored-by: J-N-K <J-N-K@users.noreply.github.com> Co-authored-by: sancho-sumy <59047465+sancho-sumy@users.noreply.github.com> Co-authored-by: Gerwin Lammers <59145105+lampy2@users.noreply.github.com> Co-authored-by: dathbe <github@beffa.us> Co-authored-by: thefechner <76476432+thefechner@users.noreply.github.com> Co-authored-by: Felix Schneider <45742226+Trysupe@users.noreply.github.com> Co-authored-by: Wouter Born <github@maindrain.net> Co-authored-by: BertramVielsack <53342169+BertramVielsack@users.noreply.github.com> Co-authored-by: mueller-ma <mueller-ma@users.noreply.github.com> Co-authored-by: lukiep111 <lukiep@outlook.com> Co-authored-by: Christoph Weitkamp <github@christophweitkamp.de>
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 11, 2023
…stem channe type 'low-battery' (openhab#2069) Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> GitOrigin-RevId: 88253c8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Christoph Weitkamp github@christophweitkamp.de