Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[automation] Avoid disappearing rules by correctly checking the model and its type #2077

Merged
merged 2 commits into from
Jan 6, 2021

Conversation

kaikreuzer
Copy link
Member

Fixes #2022

Signed-off-by: Kai Kreuzer kai@openhab.org

Signed-off-by: Kai Kreuzer <kai@openhab.org>
@kaikreuzer kaikreuzer added bug An unexpected problem or unintended behavior of the Core automation labels Jan 5, 2021
@kaikreuzer kaikreuzer requested a review from a team January 5, 2021 21:15
Signed-off-by: Kai Kreuzer <kai@openhab.org>
@kaikreuzer kaikreuzer changed the title [automation] Only react upon changes in rule models to avoid rules disappearing [automation] Avoid disappearing rules by correctly checking the model and its type Jan 5, 2021
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixing this annoying issue!

@wborn wborn merged commit 97e2782 into openhab:master Jan 6, 2021
@wborn wborn added this to the 3.1 milestone Jan 6, 2021
@cweitkamp cweitkamp added patch A PR that has been cherry-picked to a patch release branch and removed patch A PR that has been cherry-picked to a patch release branch labels Jan 10, 2021
@kaikreuzer kaikreuzer deleted the itemrule branch January 11, 2021 19:24
@kaikreuzer kaikreuzer added the patch A PR that has been cherry-picked to a patch release branch label Jan 11, 2021
kaikreuzer added a commit to kaikreuzer/openhab-core that referenced this pull request Jan 11, 2021
… and its type (openhab#2077)

Signed-off-by: Kai Kreuzer <kai@openhab.org>
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 11, 2023
… and its type (openhab#2077)

Signed-off-by: Kai Kreuzer <kai@openhab.org>
GitOrigin-RevId: 97e2782
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation bug An unexpected problem or unintended behavior of the Core patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OH3.0.0 stable: DSL Rules are removed after reload of other .rules and .items files with same file prefix
3 participants