-
-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate micrometer metering #2133
Conversation
I saw a Micrometer presentation once and ever since put it on my todo list to start integrating it into projects. So thanks for creating this PR. 👍 |
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/3rd-party-maven-dependencies-in-openhab-core/113722/2 |
e9537af
to
d2f12a2
Compare
d2f12a2
to
40efbee
Compare
Signed-off-by: Robert Bach <openhab@mortalsilence.net>
40efbee
to
2281bf6
Compare
I think this is in a state where it can be reviewed. Not much action to be seen without the addon PR, though. |
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/new-add-on-bundle-for-prometheus-health-metrics/48094/46 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks @pravussum, this looks awesome to me!
From my perspective, it's ready to merge.
Since I have never worked with micrometer so far, I'd be happy for a second review by @wborn or @cweitkamp, though.
@openhab/core-maintainers If you're not too familiar with it yourself and don't find the time for a review here, it is absolutely fine and I'd just go ahead and merge. |
I am afraid I will not have time to test it now. Fell free to merge this PR. I will test it afterwards in my prod environment. |
Fair enough, let's merge then - thanks @pravussum, looking forward to your work on the add-on side! |
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/how-to-move-a-github-issue-to-the-right-repo/147489/1 |
Signed-off-by: Robert Bach <openhab@mortalsilence.net> GitOrigin-RevId: f061512
This is the initial draft of the micrometer integration to address #774.
I figured the best place to put it would be the already existing core.io.monitoring bundle. I'll move it otherwise.
Some notes:
Some questions:
/cc @kaikreuzer