Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[timer] Fix to allow timer reschedule after termination #2153

Merged
merged 1 commit into from
Jan 26, 2021
Merged

[timer] Fix to allow timer reschedule after termination #2153

merged 1 commit into from
Jan 26, 2021

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Jan 24, 2021

Fix #2131

@jimtng
[timer] fix to allow timer reschedule after termination
dd69200 
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@jimtng jimtng requested a review from a team as a code owner January 24, 2021 21:55
Mywk
Mywk approved these changes Jan 26, 2021
View reviewed changes
Copy link

@Mywk Mywk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it for me 👍🏻

@kaikreuzer kaikreuzer changed the title [timer] fix to allow timer reschedule after termination [timer] Fix to allow timer reschedule after termination Jan 26, 2021
kaikreuzer
kaikreuzer approved these changes Jan 26, 2021
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that the JavaDoc and the implementation showed such a mismatch.
But I don't see any reason against this feature, so I agree to keep the doc and adapt the implementation. Thanks for the PR!

@kaikreuzer kaikreuzer added the bug An unexpected problem or unintended behavior of the Core label Jan 26, 2021
@kaikreuzer kaikreuzer added this to the 3.1 milestone Jan 26, 2021
@kaikreuzer kaikreuzer merged commit b55933d into openhab:main Jan 26, 2021
cweitkamp pushed a commit that referenced this pull request Feb 6, 2021
@jimtng @cweitkamp
[timer] fix to allow timer reschedule after termination (#2153)
879cec4 
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@cweitkamp cweitkamp added the patch A PR that has been cherry-picked to a patch release branch label Feb 6, 2021
@jimtng jimtng deleted the timer-reschedule branch March 18, 2023 08:57
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 11, 2023
@jimtng @splatch
[timer] fix to allow timer reschedule after termination (openhab#2153)
6fa37ea 
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
GitOrigin-RevId: b55933d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mywk Mywk Mywk approved these changes

@kaikreuzer kaikreuzer kaikreuzer approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of the Core patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.

[OH3] Rescheduling timer failed
4 participants
@jimtng @kaikreuzer @Mywk @cweitkamp