Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[voice] Changed annotation of getPreferredVoice method to allow null results #2186

Merged
merged 2 commits into from
Feb 9, 2021
Merged

[voice] Changed annotation of getPreferredVoice method to allow null results #2186

merged 2 commits into from
Feb 9, 2021

Conversation

cweitkamp
Copy link
Contributor

@cweitkamp cweitkamp commented Feb 8, 2021 •
edited
Loading

  • Added nullness annotations to VoiceManagerImpl in 7eb3a9f
  • Changed annotation of getPreferredVoice method to allow null results in db9a6d9

See https://community.openhab.org/t/openhab-3-google-tts/116531

Signed-off-by: Christoph Weitkamp github@christophweitkamp.de

@cweitkamp
Added nullness annotations to VoiceManagerImpl
7eb3a9f 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
@cweitkamp
Changed annotation of 'getPreferredVoice' method to allow null results
db9a6d9 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
@cweitkamp cweitkamp added bug An unexpected problem or unintended behavior of the Core API breaking labels Feb 8, 2021
@cweitkamp cweitkamp requested a review from a team as a code owner February 8, 2021 19:06
wborn
wborn approved these changes Feb 9, 2021
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@wborn wborn merged commit 76e0cfd into openhab:main Feb 9, 2021
@cweitkamp cweitkamp deleted the feature-voicemanager branch February 9, 2021 19:34
@cweitkamp cweitkamp added this to the 3.1 milestone Feb 9, 2021
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/openhab-3-google-tts/116531/5

splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 11, 2023
@cweitkamp @splatch
[voice] Changed annotation of getPreferredVoice method to allow nul…
13bd5b4 
…l results (openhab#2186)

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
GitOrigin-RevId: 76e0cfd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wborn wborn wborn approved these changes

Assignees
No one assigned
Labels
API breaking bug An unexpected problem or unintended behavior of the Core
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.
3 participants
@cweitkamp @openhab-bot @wborn