[modbus] Modbus poolconfig handling #2199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taking into consideration that we always have default EndpointPoolConfiguration Signed-off-by: Sami Salonen <ssalonen@gmail.com>
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 11, 2023
* [modbus] More strict nullness annotations Taking into consideration that we always have default EndpointPoolConfiguration * [modbus] Utilize default pool configuration consistently * [modbus] Make (internal) ModbusCommunicationInterfaceImpl constr private * [modbus] Handle null config of modbus comm when detecting open conns * [modbus] default connection timeout of 10s with default pool config Signed-off-by: Sami Salonen <ssalonen@gmail.com> GitOrigin-RevId: ebda155
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fixes and consistency improvements when utilizing default
EndpointPoolConfiguration, i.e. creatingnewModbusCommunicationInterfacewithnullconfiguration.Note: this code path is never executed with real openHAB bindings as they always construct
EndpointPoolConfigurationexplicitly. openhab/openhab-addons#10147 ensures that allEndpointPoolConfigurationparameters have the correct defaults