-
-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[automation] Fixed memory leak caused by invalid UI DSL rule #2212
Conversation
Signed-off-by: Mark Hilbush <mark@hilbush.com>
Signed-off-by: Mark Hilbush <mark@hilbush.com>
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks, @mhilbush!
try { | ||
resource.delete(Collections.emptyMap()); | ||
} catch(IOException e) { | ||
// Do nothing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general it isn't a bad idea to at least do a debug logging in such a situation, but I'm ok without it here.
Signed-off-by: Mark Hilbush <mark@hilbush.com>
FTR, I have cherry-picked this to 3.0.x as well. |
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/oh3-daily-crushes-fixing-status/118793/9 |
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
Fixes #2200
Signed-off-by: Mark Hilbush mark@hilbush.com