Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[automation] Fixed memory leak caused by invalid UI DSL rule #2212

Merged
merged 2 commits into from
Feb 20, 2021

Conversation

mhilbush
Copy link
Contributor

Fixes #2200

Signed-off-by: Mark Hilbush mark@hilbush.com

Signed-off-by: Mark Hilbush <mark@hilbush.com>
Signed-off-by: Mark Hilbush <mark@hilbush.com>
@mhilbush mhilbush requested a review from a team as a code owner February 20, 2021 17:17
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/openhab-3-runs-out-of-memory-java-heap-space-errors-cpu-100-after-a-few-hours/110924/133

Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks, @mhilbush!

try {
resource.delete(Collections.emptyMap());
} catch(IOException e) {
// Do nothing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general it isn't a bad idea to at least do a debug logging in such a situation, but I'm ok without it here.

@kaikreuzer kaikreuzer merged commit 7de57f9 into openhab:main Feb 20, 2021
@kaikreuzer kaikreuzer added the bug An unexpected problem or unintended behavior of the Core label Feb 20, 2021
@kaikreuzer kaikreuzer added this to the 3.1 milestone Feb 20, 2021
kaikreuzer pushed a commit that referenced this pull request Feb 20, 2021
Signed-off-by: Mark Hilbush <mark@hilbush.com>
@kaikreuzer
Copy link
Member

FTR, I have cherry-picked this to 3.0.x as well.

@kaikreuzer kaikreuzer added the patch A PR that has been cherry-picked to a patch release branch label Feb 20, 2021
@mhilbush mhilbush deleted the ui-dsl-mem-fix2 branch February 22, 2021 14:19
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/oh3-unstable-crash-after-few-days-high-load-and-memory-usage-knx/117879/2

@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/oh3-daily-crushes-fixing-status/118793/9

@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/openhab-3-runs-out-of-memory-java-heap-space-errors-cpu-100-after-a-few-hours/110924/152

splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 11, 2023
…#2212)

Signed-off-by: Mark Hilbush <mark@hilbush.com>
GitOrigin-RevId: 7de57f9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of the Core patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[automation] memory leak caused by bad rule in UI
3 participants