Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Crowdin updates #2293

Merged
merged 33 commits into from
Apr 19, 2021
Merged

New Crowdin updates #2293

merged 33 commits into from
Apr 19, 2021

Conversation

openhab-bot
Copy link
Collaborator

No description provided.

@openhab-bot openhab-bot requested a review from a team as a code owner April 15, 2021 18:20
@wborn wborn mentioned this pull request Apr 15, 2021
Copy link
Contributor

@cweitkamp cweitkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I think we can merge these new translations now.

@lolodomo
Copy link
Contributor

I made few little changes in the French translation using Crowdin. But I have no idea how to trigger the PR in Git.

@wborn
Copy link
Member

wborn commented Apr 19, 2021

Thanks! I pressed a button ⏯️ ... are these the changes you had expected?

@lolodomo
Copy link
Contributor

Thanks! I pressed a button ⏯️ ... are these the changes you had expected?

I see files I approved (without any changes) but I don't see the translations I fixed (and approved).

@cweitkamp
Copy link
Contributor

If you are looking for translations of DefaultSystemChannelTypes or Profiles - they are not yet in sync. We have to merge #2297 first.

@lolodomo
Copy link
Contributor

If you are looking for translations of DefaultSystemChannelTypes or Profiles - they are not yet in sync. We have to merge #2297 first.

Ok for DefaultSystemChannelTypes, yes I fixed 2 in this file.

But I also fixed one entry in messages.properties (auth) which I don't find here.

@wborn
Copy link
Member

wborn commented Apr 19, 2021

Do you now see all the changes? 🙂

@lolodomo
Copy link
Contributor

Yes, now they are pressent.

@lolodomo
Copy link
Contributor

Someone just applied strange changes in units translations (in Crowdin) leading to a new strange value for celsius. The value was previously correct and I even validated it earlier in the day.

@wborn
Copy link
Member

wborn commented Apr 19, 2021

Crowdin probably regenerates default translations on commits and expects these files to be in UTF-8, whereas some files currently still have a ISO-8859-1 encoding (see #2137 (comment)). So if the UTF-8 files work well with Java 11, we probably want to use UTF-8 with all these files.

Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UTF-8 encoded files seem to work well with Java 11, so let's merge this.

@wborn wborn merged commit 4afbf93 into main Apr 19, 2021
@wborn wborn deleted the l10n_crowdin branch April 19, 2021 16:43
@cweitkamp
Copy link
Contributor

Nice. Let's start to translate OHC. 👍

@cweitkamp cweitkamp added this to the 3.1 milestone May 2, 2021
fwolter pushed a commit to fwolter/openhab-core that referenced this pull request May 24, 2021
* New translations DefaultSystemChannels.properties (Finnish)
* New translations DefaultSystemChannels.properties (French)
* New translations DefaultSystemChannels.properties (German)
* New translations DefaultSystemChannels.properties (Hebrew)
* New translations DefaultSystemChannels.properties (Portuguese, Brazilian)
* New translations firmware.properties (Czech)
* New translations firmware.properties (French)
* New translations firmware.properties (German)
* New translations firmware.properties (Hungarian)
* New translations LanguageSupport.properties (Czech)
* New translations LanguageSupport.properties (German)
* New translations LanguageSupport.properties (Hungarian)
* New translations LanguageSupport.properties (Japanese)
* New translations LanguageSupport.properties (Portuguese, Brazilian)
* New translations messages.properties (Czech)
* New translations messages.properties (French)
* New translations messages.properties (German)
* New translations messages.properties (Hungarian)
* New translations messages.properties (Portuguese, Brazilian)
* New translations SystemProfiles.properties (Finnish)
* New translations SystemProfiles.properties (Italian)
* New translations SystemProfiles.properties (Portuguese, Brazilian)
* New translations tags.properties (Hungarian)
* New translations tags.properties (Portuguese, Brazilian)
* New translations units.properties (Czech)
* New translations units.properties (French)
* New translations units.properties (German)
* New translations units.properties (Hungarian)
* New translations validation.properties (Czech)
* New translations validation.properties (German)
* New translations validation.properties (Hungarian)
* New translations validation.properties (Japanese)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants