-
-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Crowdin updates #2293
New Crowdin updates #2293
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I think we can merge these new translations now.
I made few little changes in the French translation using Crowdin. But I have no idea how to trigger the PR in Git. |
Thanks! I pressed a button ⏯️ ... are these the changes you had expected? |
I see files I approved (without any changes) but I don't see the translations I fixed (and approved). |
If you are looking for translations of DefaultSystemChannelTypes or Profiles - they are not yet in sync. We have to merge #2297 first. |
Ok for DefaultSystemChannelTypes, yes I fixed 2 in this file. But I also fixed one entry in messages.properties (auth) which I don't find here. |
Do you now see all the changes? 🙂 |
Yes, now they are pressent. |
Someone just applied strange changes in units translations (in Crowdin) leading to a new strange value for celsius. The value was previously correct and I even validated it earlier in the day. |
Crowdin probably regenerates default translations on commits and expects these files to be in UTF-8, whereas some files currently still have a ISO-8859-1 encoding (see #2137 (comment)). So if the UTF-8 files work well with Java 11, we probably want to use UTF-8 with all these files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The UTF-8 encoded files seem to work well with Java 11, so let's merge this.
Nice. Let's start to translate OHC. 👍 |
* New translations DefaultSystemChannels.properties (Finnish) * New translations DefaultSystemChannels.properties (French) * New translations DefaultSystemChannels.properties (German) * New translations DefaultSystemChannels.properties (Hebrew) * New translations DefaultSystemChannels.properties (Portuguese, Brazilian) * New translations firmware.properties (Czech) * New translations firmware.properties (French) * New translations firmware.properties (German) * New translations firmware.properties (Hungarian) * New translations LanguageSupport.properties (Czech) * New translations LanguageSupport.properties (German) * New translations LanguageSupport.properties (Hungarian) * New translations LanguageSupport.properties (Japanese) * New translations LanguageSupport.properties (Portuguese, Brazilian) * New translations messages.properties (Czech) * New translations messages.properties (French) * New translations messages.properties (German) * New translations messages.properties (Hungarian) * New translations messages.properties (Portuguese, Brazilian) * New translations SystemProfiles.properties (Finnish) * New translations SystemProfiles.properties (Italian) * New translations SystemProfiles.properties (Portuguese, Brazilian) * New translations tags.properties (Hungarian) * New translations tags.properties (Portuguese, Brazilian) * New translations units.properties (Czech) * New translations units.properties (French) * New translations units.properties (German) * New translations units.properties (Hungarian) * New translations validation.properties (Czech) * New translations validation.properties (German) * New translations validation.properties (Hungarian) * New translations validation.properties (Japanese)
No description provided.