Upgrade Units of Measurement dependencies #2319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wborn
added
dependencies
This was referenced Apr 26, 2021
Upgrades UoM dependencies to: * javax.measure 2.1.2 * si-units 2.0.1 * indriya 2.1.2 An openHAB OSGi-ified si-units bundle is used as runtime dependency, because the latest si-units release is still missing proper OSGi manifest headers. Notable changes: * Quantity not longer implements an `equals` method, so the unit tests had to be adjusted. This should have any impact outside of the unit tests though since the rest of openHAB should be using QuantityType instead. * RationalConverter is not package private, so instances of it much be created through the MultiplyConverter static functions. * Quantities.getQuantity can no longer parse values without units like `100`. A workaround has been implemented. * The unicode greek `mu` letter is now returned for unit prefixes instead of the unicode `micro` character. These characters are visually identical but the unit tests had to be adjusted. The new library seems to parse both types just fine. Also-by: Connor Petty <mistercpp2000+gitsignoff@gmail.com> Signed-off-by: Wouter Born <github@maindrain.net>
wborn
added
UoM
cweitkamp
added
rebuild
wborn
added
rebuild
|
Ah, success! 😄 |
|
Friendly "ready for review" ping @openhab/core-maintainers. |
kaikreuzer
approved these changes
May 10, 2021
Closed
|
Edit: never mind I just saw the other freshly merged PRs I incidentally installed the latest snapshot - which I haven't done in weeks - and now none of the addons install 😢 Presumably it's because of this change. I have indeed the UoM library in version 2.x now: Is there something to do on my side to fix this? |
|
Yes build # 2373 unfortunately didn't have all changes. |
|
2374 works indeed, I was unlucky, now everything's fine - sorry for the bother! |
|
I did have some new UoM exceptions related to rrd4j on start though - but it was a couple times on start and now I can't reproduce them. I don't know which items they related to. Charting items with dimensions from the UI seems to work as before. |
|
Thanks for reporting it. I will keep an eye on my logs and see if I can reproduce it. There have been quite a few changes in the new UoM implementation, so I can imagine there are also a few regressions. |
|
I added the "API breaking" label. Some bundles might need to adopt their code to handle the new |
|
Hi, some more errors: e.g. openweather binding: Current dew point 908,0 °C, Current Gust Speed 1728,0 km/h |
t-8ch
added a commit
to t-8ch/openhab-binding-wmbus
that referenced
this pull request
May 16, 2021
fwolter
pushed a commit
to fwolter/openhab-core
that referenced
this pull request
May 24, 2021
Upgrades UoM dependencies to: * javax.measure 2.1.2 * si-units 2.0.1 * indriya 2.1.2 An openHAB OSGi-ified si-units bundle is used as runtime dependency, because the latest si-units release is still missing proper OSGi manifest headers. Notable changes: * Quantity not longer implements an `equals` method, so the unit tests had to be adjusted. This should have any impact outside of the unit tests though since the rest of openHAB should be using QuantityType instead. * RationalConverter is not package private, so instances of it much be created through the MultiplyConverter static functions. * Quantities.getQuantity can no longer parse values without units like `100`. A workaround has been implemented. * The unicode greek `mu` letter is now returned for unit prefixes instead of the unicode `micro` character. These characters are visually identical but the unit tests had to be adjusted. The new library seems to parse both types just fine. Also-by: Connor Petty <mistercpp2000+gitsignoff@gmail.com> Signed-off-by: Wouter Born <github@maindrain.net>
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/resol-binding-stopped-working-in-recent-nightly-builds/122371/4 |
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/openhab-3-1-milestone-discussion/116025/181 |
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/broadlink-binding-for-rmx-a1-spx-and-mp-any-interest/22768/1392 |
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
J-N-K
reviewed
Nov 26, 2022
| quantity = (Quantity<T>) Quantities.getQuantity(formatted); | ||
| if (!formatted.contains(" ")) { | ||
| BigDecimal bd = new BigDecimal(value); | ||
| quantity = (Quantity<T>) Quantities.getQuantity(bd, AbstractUnit.ONE, Scale.RELATIVE); |
There was a problem hiding this comment.
There was a problem hiding this comment.
IIRC such a change would cause a lot more rules to break.
There was a problem hiding this comment.
I didn't want to suggest changing it. I was just wondering if this was a deliberate decision or not. Because #3177 only works because of this.
There was a problem hiding this comment.
If there was no legacy code and there were no openHAB users I would also opt for using all the default behaviors. 🙂
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 11, 2023
Upgrades UoM dependencies to: * javax.measure 2.1.2 * si-units 2.0.1 * indriya 2.1.2 An openHAB OSGi-ified si-units bundle is used as runtime dependency, because the latest si-units release is still missing proper OSGi manifest headers. Notable changes: * Quantity not longer implements an `equals` method, so the unit tests had to be adjusted. This should have any impact outside of the unit tests though since the rest of openHAB should be using QuantityType instead. * RationalConverter is not package private, so instances of it much be created through the MultiplyConverter static functions. * Quantities.getQuantity can no longer parse values without units like `100`. A workaround has been implemented. * The unicode greek `mu` letter is now returned for unit prefixes instead of the unicode `micro` character. These characters are visually identical but the unit tests had to be adjusted. The new library seems to parse both types just fine. Also-by: Connor Petty <mistercpp2000+gitsignoff@gmail.com> Signed-off-by: Wouter Born <github@maindrain.net> GitOrigin-RevId: 9130799
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1664
Depends on openhab/openhab-osgiify#19
Upgrades UoM dependencies to:
An openHAB OSGi-ified si-units bundle is used as runtime dependency, because the latest si-units release is still missing proper OSGi manifest headers.
Notable changes:
equalsmethod, so the unit tests had to be adjusted. This should have any impact outside of the unit tests though since the rest of openHAB should be using QuantityType instead.100. A workaround has been implemented.muletter is now returned for unit prefixes instead of the unicodemicrocharacter. These characters are visually identical but the unit tests had to be adjusted. The new library seems to parse both types just fine.